Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile so that image supports "make software". #210

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tcal-x
Copy link
Collaborator

@tcal-x tcal-x commented Aug 4, 2021

I ran into errors when I tried to run cd proj/proj_template_v && make software inside a container running the generated image, so I changed mkdir to mkdir -p, and added unzip and curl to the installed packages.

My commands to build and execute were:

$ docker build -t tims-image .
$ docker run -p 8080:80 -it tims-image  bash

and then cd to proj/proj_template_v and run make software.

Signed-off-by: Tim Callahan [email protected]

@tcal-x
Copy link
Collaborator Author

tcal-x commented Aug 4, 2021

@PiotrZierhoffer fyi

@tcal-x tcal-x requested a review from PiotrZierhoffer August 4, 2021 15:17
tcal-x added 2 commits August 10, 2021 13:08
These missing packages were discovered trying to build/run with docker.

Signed-off-by: Tim Callahan <[email protected]>
@tcal-x
Copy link
Collaborator Author

tcal-x commented Aug 10, 2021

@PiotrZierhoffer , I noticed that the Dockerfile installs a list of all the needed apt packages itself, instead of relying on the call to ./scripts/setup. It would be nice to test the completeness of ./scripts/setup here. I realize we need to make sure 'git' is installed in order to clone the repo in order to get the setup script, but other than that, is there a reason we can't just use ./scripts/setup? And then do rm -rf /var/lib/apt/lists/* as the final step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant