Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Enable dry-run sweeps. #89

Merged
merged 2 commits into from
Jan 4, 2022
Merged

Enable dry-run sweeps. #89

merged 2 commits into from
Jan 4, 2022

Conversation

dbieber
Copy link
Contributor

@dbieber dbieber commented Jan 4, 2022

A dry-run sweep generates the commands for the sweep without running them. This is useful for resuming old runs on different machines than they were originally run on, or for resuming just a subset of old runs.

@dbieber dbieber requested a review from dan-zheng January 4, 2022 20:03
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -196,159 +202,159 @@ def main(experiment_id=None, study_id=None, dataset_path=None, skip_create=False
# overrides = {
# 'config.raise_in_ipagnn': False,
# }
# run_sweep(n, offset, experiment_id, study_id, 'IN', 'IPAGNN', overrides, dataset_path, skip_create)
# run_sweep(n, offset, experiment_id, study_id, 'IN', 'IPAGNN', overrides, dataset_path, skip_create, dry_run, dry_run)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extra dry_run argument here?

Suggested change
# run_sweep(n, offset, experiment_id, study_id, 'IN', 'IPAGNN', overrides, dataset_path, skip_create, dry_run, dry_run)
# run_sweep(n, offset, experiment_id, study_id, 'IN', 'IPAGNN', overrides, dataset_path, skip_create, dry_run)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@dbieber dbieber merged commit a4d0fcf into main Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants