Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nisaba] Use required=True instead of mark_flag_as_required in absl flags #492

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[nisaba] Use required=True instead of mark_flag_as_required in absl flags #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions nisaba/scripts/utils/letter_languages_integrity_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
from nisaba.scripts.utils import letter_languages

_INPUT = flags.DEFINE_string(
'input_text_proto', None,
'Input text proto file in `nisaba.LetterLanguages` format.')
flags.mark_flag_as_required('input_text_proto')
'input_text_proto',
None,
'Input text proto file in `nisaba.LetterLanguages` format.',
required=True,
)


class LetterLanguagesIntegrityTest(absltest.TestCase):
Expand Down
25 changes: 16 additions & 9 deletions nisaba/scripts/utils/unicode_strings_to_tsv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,24 @@
from nisaba.scripts.utils import unicode_strings_util as lib

_INPUT = flags.DEFINE_string(
'input_text_proto', None,
('Input proto file in textual format corresponding to '
'`nisaba.UnicodeStrings` protocol buffer message.'))
'input_text_proto',
None,
(
'Input proto file in textual format corresponding to '
'`nisaba.UnicodeStrings` protocol buffer message.'
),
required=True,
)

_OUTPUT = flags.DEFINE_string(
'output_tsv', None,
('Output file in tab-separated (tsv) format ready for consumption by '
'Pynini/Thrax grammars.'))

flags.mark_flag_as_required('input_text_proto')
flags.mark_flag_as_required('output_tsv')
'output_tsv',
None,
(
'Output file in tab-separated (tsv) format ready for consumption by '
'Pynini/Thrax grammars.'
),
required=True,
)


def _convert_data_proto_to_file(data_proto: unicode_strings_pb2.UnicodeStrings):
Expand Down
Loading