Support Windows Platform

android_world/env/adb_utils.py

@@ -1015,7 +1015,7 @@ def extract_broadcast_data(raw_output: str) -> Optional[str]:
     Extracted data as a string, or None if the result is 0.
   """
   if 'Broadcast completed: result=-1, data=' in raw_output:
-    return raw_output.split('data=')[1].strip('"\n')
+    return raw_output.split('data=')[1].strip('"\r\n')
   elif 'Broadcast completed: result=0' in raw_output:
     return None
   else:

android_world/env/android_world_controller.py

@@ -103,7 +103,7 @@ def get_a11y_tree(
   return forest
 
 
-_TASK_PATH = '/tmp/default.textproto'
+_TASK_PATH = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), 'default.textproto')
 DEFAULT_ADB_PATH = '~/Android/Sdk/platform-tools/adb'
 
 

android_world/env/android_world_controller_test.py

@@ -30,7 +30,7 @@
 
 def create_file_with_contents(contents: str) -> str:
   temp_dir = tempfile.mkdtemp()
-  file_path = os.path.join(temp_dir, 'file.txt')
+  file_path = file_utils.convert_to_posix_path(temp_dir, 'file.txt')
   with open(file_path, 'w') as f:
     f.write(contents)
   return file_path
@@ -169,7 +169,7 @@ def test_pull_file(self):
 
     with env.pull_file(remote_file_path) as local_dir:
       local_path = os.path.split(remote_file_path)[1]
-      local_file = open(os.path.join(local_dir, local_path), 'r')
+      local_file = open(file_utils.convert_to_posix_path(local_dir, local_path), 'r')
       self.assertEqual(open(remote_file_path, 'r').read(), local_file.read())
 
     self.mock_copy_db.assert_called_once_with(

android_world/env/setup_device/apps.py

@@ -32,16 +32,16 @@
 import requests
 
 
-APP_DATA = os.path.join(os.path.dirname(__file__), 'app_data')
+APP_DATA = file_utils.convert_to_posix_path(os.path.dirname(__file__), 'app_data')
 
 
 def download_app_data(file_name: str) -> str:
   """Downloads file from a GCS bucket, if not cached, and installs it."""
-  cache_dir = "/tmp/android_world/app_data"
+  cache_dir = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), 'android_world', 'app_data')
   remote_url = (
       f"https://storage.googleapis.com/gresearch/android_world/{file_name}"
   )
-  full_path = os.path.join(cache_dir, file_name)
+  full_path = file_utils.convert_to_posix_path(cache_dir, file_name)
   os.makedirs(cache_dir, exist_ok=True)
   if not os.path.isfile(full_path):
     logging.info("Downloading file_name %s to cache %s", file_name, cache_dir)
@@ -580,7 +580,7 @@ def setup(cls, env: interface.AsyncEnv) -> None:
                   "shell",
                   "chcon",
                   "u:object_r:media_rw_data_file:s0",
-                  os.path.join(cls.DEVICE_MAPS_PATH, map_file),
+                  file_utils.convert_to_posix_path(cls.DEVICE_MAPS_PATH, map_file),
               ],
               env.controller,
           )

android_world/task_evals/common_validators/file_validators.py

@@ -44,10 +44,10 @@ class MoveFile(task_eval.TaskEval):
   def __init__(self, params: dict[str, Any], data_directory: str):
     """Initialize the task."""
     super().__init__(params)
-    self.source_directory = os.path.join(
+    self.source_directory = file_utils.convert_to_posix_path(
         data_directory, self.params["source_folder"]
     )
-    self.dest_directory = os.path.join(
+    self.dest_directory = file_utils.convert_to_posix_path(
         data_directory, self.params["destination_folder"]
     )
 
@@ -123,7 +123,7 @@ def __init__(self, params: dict[str, Any], data_directory: str):
     """
     super().__init__(params)
     if "subfolder" in self.params:
-      self.data_directory = os.path.join(
+      self.data_directory = file_utils.convert_to_posix_path(
           data_directory, self.params["subfolder"]
       )
     else:
@@ -214,7 +214,7 @@ def is_successful(self, env: interface.AsyncEnv) -> float:
         [
             "shell",
             "cat",
-            os.path.join(self.data_directory, file_name),
+            file_utils.convert_to_posix_path(self.data_directory, file_name),
         ],
         env.controller,
     )

android_world/task_evals/common_validators/sms_validators.py

@@ -48,6 +48,7 @@ def parse_message(row: str) -> dict[str, str]:
   """
   parsed_dict = {}
 
+  row = row.strip()
   body_start = row.find("body=")
 
   if body_start != -1:

android_world/task_evals/information_retrieval/information_retrieval_registry.py

@@ -24,6 +24,7 @@
 from typing import Any, Generic, Type, TypeVar
 from android_world.task_evals.information_retrieval import information_retrieval
 from android_world.task_evals.information_retrieval.proto import task_pb2
+from android_world.utils import file_utils
 from google.protobuf import text_format
 
 TaskType = TypeVar('TaskType', bound=information_retrieval.InformationRetrieval)
@@ -50,7 +51,7 @@ def registry(
   def _read_tasks(self) -> task_pb2.Tasks:
     proto = task_pb2.Tasks()
     script_dir = os.path.dirname(os.path.abspath(__file__))
-    local_path = os.path.join(script_dir, 'proto', 'tasks.textproto')
+    local_path = file_utils.convert_to_posix_path(script_dir, 'proto', 'tasks.textproto')
     with open(local_path, 'r') as f:
       textproto_content = f.read()
     text_format.Merge(textproto_content, proto)

android_world/task_evals/information_retrieval/joplin_app_utils.py

@@ -24,6 +24,7 @@
 from android_world.task_evals.information_retrieval.proto import task_pb2
 from android_world.task_evals.utils import sqlite_schema_utils
 from android_world.task_evals.utils import sqlite_utils
+from android_world.utils import file_utils
 
 _NOTES_TABLE = "notes"
 _NOTES_NORMALIZED_TABLE = "notes_normalized"
@@ -84,7 +85,7 @@ def _get_folder_to_id(
 ) -> dict[str, str]:
   """Gets a mapping from folder title to ID as represented in Folder table."""
   with env.controller.pull_file(_DB_PATH) as local_db_directory:
-    local_db_path = os.path.join(local_db_directory, os.path.split(_DB_PATH)[1])
+    local_db_path = file_utils.convert_to_posix_path(local_db_directory, os.path.split(_DB_PATH)[1])
     folder_info = sqlite_utils.execute_query(
         f"select * from {_FOLDER_TABLE};",
         local_db_path,

android_world/task_evals/single/browser.py

@@ -72,11 +72,12 @@ def initialize_task(self, env: interface.AsyncEnv):
     )
 
     html = self.HTML.replace('%%SEED%%', str(self.params['browser_task_seed']))
-    with open('/tmp/task.html', 'w') as f:
+    task_html_path = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), 'task.html')
+    with open(task_html_path, 'w') as f:
       f.write(html)
     file_utils.copy_data_to_device(
-        '/tmp/task.html',
-        os.path.join(device_constants.DOWNLOAD_DATA, 'task.html'),
+        task_html_path,
+        file_utils.convert_to_posix_path(device_constants.DOWNLOAD_DATA, 'task.html'),
         env.controller,
     )
 

android_world/task_evals/single/markor.py

@@ -228,7 +228,7 @@ def is_successful(self, env: interface.AsyncEnv) -> float:
         [
             "shell",
             "cat",
-            os.path.join(
+            file_utils.convert_to_posix_path(
                 device_constants.MARKOR_DATA, self.params["file_name"]
             ),
         ],
@@ -614,7 +614,7 @@ def is_successful(self, env: interface.AsyncEnv) -> float:
             [
                 "shell",
                 "cat",
-                os.path.join(
+                file_utils.convert_to_posix_path(
                     device_constants.MARKOR_DATA, self.params["new_file_name"]
                 ),
             ],
@@ -711,7 +711,7 @@ def is_successful(self, env: interface.AsyncEnv) -> float:
     ):
       return 0.0
     content_updated = file_utils.check_file_content(
-        os.path.join(device_constants.MARKOR_DATA, self.params["new_name"]),
+        file_utils.convert_to_posix_path(device_constants.MARKOR_DATA, self.params["new_name"]),
         self.params["updated_content"],
         env.controller,
     )
@@ -793,7 +793,7 @@ def is_successful(self, env: interface.AsyncEnv) -> float:
     ):
       return 0.0
     correct = file_utils.check_file_content(
-        os.path.join(device_constants.MARKOR_DATA, self.params["new_name"]),
+        file_utils.convert_to_posix_path(device_constants.MARKOR_DATA, self.params["new_name"]),
         self.params["header"] + "\n\n" + self.params["original_content"] + "\n",
         env.controller,
         exact_match=True,
@@ -840,9 +840,10 @@ def initialize_task(self, env: interface.AsyncEnv) -> None:
     """Initializes the task for creating a receipt markdown file."""
     super().initialize_task(env)
     self.create_file_task.initialize_task(env)
-    self.img.save("/tmp/receipt.png")
+    receipt_img_path = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), 'receipt.png')
+    self.img.save(receipt_img_path)
     file_utils.copy_data_to_device(
-        "/tmp/receipt.png",
+        receipt_img_path,
         device_constants.GALLERY_DATA,
         env.controller,
     )

android_world/task_evals/single/markor_test.py

@@ -346,9 +346,10 @@ def test_initialize_task(self, mock_copy_data_to_device):
 
     task.initialize_task(mock_env)
 
-    task.img.save.assert_called_once_with('/tmp/receipt.png')
+    receipt_img_path = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), 'receipt.png')
+    task.img.save.assert_called_once_with(receipt_img_path)
     mock_copy_data_to_device.assert_called_once_with(
-        '/tmp/receipt.png',
+        receipt_img_path,
         device_constants.GALLERY_DATA,
         mock_env.controller,
     )

android_world/task_evals/single/osmand.py

@@ -31,9 +31,9 @@
 
 _DEVICE_FILES = '/data/media/0/Android/data/net.osmand/files'
 _LEGACY_FILES = '/data/data/net.osmand/files'
-_FAVORITES_PATH = os.path.join(_DEVICE_FILES, 'favorites/favorites.gpx')
-_LEGACY_FAVORITES_PATH = os.path.join(_LEGACY_FILES, 'favourites_bak.gpx')
-_BACKUP_DIR_PATH = os.path.join(_LEGACY_FILES, 'backup')
+_FAVORITES_PATH = file_utils.convert_to_posix_path(_DEVICE_FILES, 'favorites/favorites.gpx')
+_LEGACY_FAVORITES_PATH = file_utils.convert_to_posix_path(_LEGACY_FILES, 'favourites_bak.gpx')
+_BACKUP_DIR_PATH = file_utils.convert_to_posix_path(_LEGACY_FILES, 'backup')
 
 # Random location names and coords present in the pre-loaded Liechtenstein map.
 _PRELOADED_MAP_LOCATIONS = {
@@ -312,7 +312,7 @@ def _clear_tracks(env: env_interface.AndroidEnvInterface):
   Raises:
     RuntimeError: If there is an adb communication issue.
   """
-  adb_args = ['shell', 'rm -rf', os.path.join(_DEVICE_FILES, 'tracks', '*')]
+  adb_args = ['shell', 'rm -rf', file_utils.convert_to_posix_path(_DEVICE_FILES, 'tracks', '*')]
   # Issue ADB pull command to copy the directory
   response = adb_utils.issue_generic_request(adb_args, env)
   if response.status != adb_pb2.AdbResponse.OK:
@@ -417,13 +417,13 @@ def initialize_task(self, env: interface.AsyncEnv) -> None:
 
   def is_successful(self, env: interface.AsyncEnv) -> float:
     with file_utils.tmp_directory_from_device(
-        os.path.join(_DEVICE_FILES, 'tracks'), env.controller
+        file_utils.convert_to_posix_path(_DEVICE_FILES, 'tracks'), env.controller
     ) as tracks_directory:
       for track_file in os.listdir(tracks_directory):
         if _track_matches(
             _track_points(
                 ElementTree.parse(
-                    os.path.join(tracks_directory, track_file)
+                    file_utils.convert_to_posix_path(tracks_directory, track_file)
                 ).getroot()
             ),
             self._target_waypoint_coords,

android_world/task_evals/single/retro_music.py

@@ -66,7 +66,7 @@ def _get_playlist_data(
   with env.controller.pull_file(
       _PLAYLIST_DB_PATH, timeout_sec=3
   ) as local_db_directory:
-    local_db_path = os.path.join(
+    local_db_path = file_utils.convert_to_posix_path(
         local_db_directory, os.path.split(_PLAYLIST_DB_PATH)[1]
     )
     return sqlite_utils.execute_query(
@@ -86,7 +86,7 @@ class Queue(sqlite_schema_utils.SQLiteRow):
   with env.controller.pull_file(
       _PLAYBACK_DB_PATH, timeout_sec=3
   ) as local_db_directory:
-    local_db_path = os.path.join(
+    local_db_path = file_utils.convert_to_posix_path(
         local_db_directory, os.path.split(_PLAYBACK_DB_PATH)[1]
     )
     result = sqlite_utils.execute_query(
@@ -151,7 +151,7 @@ def initialize_task(self, env: interface.AsyncEnv):
 
     for file in self.params['files'] + self.params['noise_files']:
       user_data_generation.write_mp3_file_to_device(
-          os.path.join(device_constants.MUSIC_DATA, file),
+          file_utils.convert_to_posix_path(device_constants.MUSIC_DATA, file),
           env,
           title=file.split('.')[0],
           artist=random.choice(user_data_generation.COMMON_GIVEN_NAMES),
@@ -223,7 +223,7 @@ def goal(self) -> str:
 
   def is_successful(self, env: interface.AsyncEnv) -> float:
     playlist_exists = file_utils.check_file_exists(
-        os.path.join(
+        file_utils.convert_to_posix_path(
             device_constants.DOWNLOAD_DATA,
             self.params['playlist_name'] + '.m3u',
         ),
@@ -266,7 +266,7 @@ def initialize_task(self, env: interface.AsyncEnv):
     )
     for file, duration in zip(self.params['files'], durations):
       user_data_generation.write_mp3_file_to_device(
-          os.path.join(device_constants.MUSIC_DATA, file),
+          file_utils.convert_to_posix_path(device_constants.MUSIC_DATA, file),
           env,
           title=file.split('.')[0],
           artist=random.choice(user_data_generation.COMMON_GIVEN_NAMES),
@@ -275,7 +275,7 @@ def initialize_task(self, env: interface.AsyncEnv):
 
     for file in self.params['noise_files']:
       user_data_generation.write_mp3_file_to_device(
-          os.path.join(device_constants.MUSIC_DATA, file),
+          file_utils.convert_to_posix_path(device_constants.MUSIC_DATA, file),
           env,
           title=file.split('.')[0],
           artist=random.choice(user_data_generation.COMMON_GIVEN_NAMES),

android_world/task_evals/single/simple_draw_pro.py

@@ -40,7 +40,7 @@ def __init__(self, params: dict[str, Any]):
     super().__init__(params)
     self.initialized = False
     self.create_file_task = file_validators.CreateFile(
-        params, os.path.join(device_constants.EMULATOR_DATA, "Pictures")
+        params, file_utils.convert_to_posix_path(device_constants.EMULATOR_DATA, "Pictures")
     )
 
   def initialize_task(self, env: interface.AsyncEnv) -> None:

android_world/task_evals/single/simple_gallery_pro.py

@@ -43,7 +43,7 @@ def initialize_task(self, env: interface.AsyncEnv) -> None:
     super().initialize_task(env)
     user_data_generation.clear_device_storage(env)
     receipt_image = self.params["receipt_image"]
-    temp_storage_location = os.path.join("/tmp/", self.params["file_name"])
+    temp_storage_location = file_utils.convert_to_posix_path(file_utils.get_local_tmp_directory(), self.params["file_name"])
     receipt_image.save(temp_storage_location)
     file_utils.copy_data_to_device(
         temp_storage_location,

android_world/task_evals/single/simple_gallery_pro_test.py

@@ -26,6 +26,7 @@
 from android_world.utils import app_snapshot
 from android_world.utils import datetime_utils
 from android_world.utils import fake_adb_responses
+from android_world.utils import file_utils
 from PIL import Image
 
 
@@ -35,7 +36,7 @@ def _touch_temp_file(file_name):
   Args:
     file_name: The name of the file.
   """
-  path = os.path.join(tempfile.gettempdir(), file_name)
+  path = file_utils.convert_to_posix_path(tempfile.gettempdir(), file_name)
   with open(path, "w") as f:
     f.write("")
 

android_world/task_evals/single/vlc.py

@@ -61,7 +61,7 @@ def _get_playlist_file_info(
 ) -> list[sqlite_schema_utils.PlaylistInfo]:
   """Executes join query to fetch playlist file info."""
   with env.controller.pull_file(_DB_PATH, timeout_sec=3) as local_db_directory:
-    local_db_path = os.path.join(local_db_directory, os.path.split(_DB_PATH)[1])
+    local_db_path = file_utils.convert_to_posix_path(local_db_directory, os.path.split(_DB_PATH)[1])
     return sqlite_utils.execute_query(
         _get_playlist_info_query(),
         local_db_path,

android_world/task_evals/single/vlc_test.py

@@ -101,9 +101,9 @@ def setUp(self):
     self.env_mock.controller = self.controller
 
     temp_dir = tempfile.mkdtemp()
-    self.test_db_path = os.path.join(temp_dir, 'app_db/vlc_media.db')
+    self.test_db_path = file_utils.convert_to_posix_path(temp_dir, 'app_db/vlc_media.db')
     os.makedirs(
-        os.path.join(os.path.dirname(self.test_db_path), 'app_db'),
+        file_utils.convert_to_posix_path(os.path.dirname(self.test_db_path), 'app_db'),
         exist_ok=True,
     )
 

android_world/task_evals/utils/sqlite_test_utils.py

@@ -20,6 +20,7 @@
 
 from android_world.env import device_constants
 from android_world.task_evals.utils import sqlite_schema_utils
+from android_world.utils import file_utils
 
 
 def setup_test_db() -> str:
@@ -28,7 +29,7 @@ def setup_test_db() -> str:
   temp_dir = tempfile.mkdtemp()
 
   # Path for the new database
-  db_path = os.path.join(temp_dir, 'events.db')
+  db_path = file_utils.convert_to_posix_path(temp_dir, 'events.db')
 
   conn = sqlite3.connect(db_path)
   cursor = conn.cursor()