Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default "promote" to true #362

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Default "promote" to true #362

merged 1 commit into from
Apr 29, 2024

Conversation

sethvargo
Copy link
Member

This restores a v0 and v1 behavior wherein the empty string is considered "true" instead of "false". Fixes GH-361.

This restores a v0 and v1 behavior wherein the empty string is considered "true" instead of "false". Fixes GH-361.
@sethvargo sethvargo requested a review from a team as a code owner April 29, 2024 23:09
@sethvargo
Copy link
Member Author

@joeyparrish

@sethvargo sethvargo enabled auto-merge (squash) April 29, 2024 23:10
@sethvargo sethvargo merged commit 693d553 into main Apr 29, 2024
7 checks passed
@sethvargo sethvargo deleted the sethvargo/def branch April 29, 2024 23:12
@joeyparrish
Copy link

Thank you!

sethvargo pushed a commit that referenced this pull request Apr 29, 2024
## What's Changed
* security: bump undici from 5.28.2 to 5.28.3 by @dependabot in
#352
* Docs: Added artifact register reader permission required for ci/cd
pipeline by @hawkeye-sama in
#356
* build(deps): bump express from 4.18.2 to 4.19.2 in /example-app by
@dependabot in
#357
* security: bump undici from 5.28.3 to 5.28.4 by @dependabot in
#358
* Default "promote" to true by @sethvargo in
#362

## New Contributors
* @hawkeye-sama made their first contribution in
#356

**Full Changelog**:
v2.1.0...693d553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Promote flag default doesn't agree with docs
3 participants