Simplify streaming code for code assist server by scidomino · Pull Request #4619 · google-gemini/gemini-cli

scidomino · 2025-07-21T19:58:34Z

TLDR

Store the user tier we get during setup instead of querying for it separately. This simplifies changes made in #3662

Reviewer Test Plan

I tested this by using up all my quota and verifying that it worked properly.

Testing Matrix

	🍏	🪟	🐧
npm run	x	❓	❓
npx	❓	❓	❓
Docker	❓	❓	❓
Podman	❓	-	-
Seatbelt	❓	-	-

Linked issues / bugs

Follow up to #2711

gemini-code-assist

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the user tier management within the code assist server. Instead of dynamically querying the user's tier whenever needed, the tier is now determined and stored during the initial setup phase. This change simplifies the CodeAssistServer class, streamlines the getUserTier retrieval in the configuration, and cleans up related streaming code, leading to a more efficient and less complex architecture for handling user tier information.

Highlights

User Tier Management Refactor: The system now fetches and stores the user's tier (e.g., 'standard-tier') once during the initial setup process, eliminating the need for subsequent asynchronous queries to determine the user's tier.
CodeAssistServer Simplification: The CodeAssistServer class has been streamlined by removing its internal userTier state and associated getTier() and detectUserTier() methods. The user tier is now passed directly into its constructor.
Stream Processing Cleanup: Unnecessary stream conversion and error handling logic within CodeAssistServer's generateContentStream method have been removed, simplifying the code and relying on the assumption that res.data is a NodeJS.ReadableStream.
API Interface Update: The ContentGenerator interface has been updated to expose userTier as a direct property rather than an asynchronous method, reflecting the new synchronous access pattern.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request simplifies user tier handling by fetching it once during setup and storing it, which is a great improvement. However, the review identifies two main issues. First, a critical error handling mechanism for streaming responses in CodeAssistServer has been removed, which could lead to application crashes on certain API errors. Second, a runtime null check in GeminiClient was replaced with a non-null assertion, which reduces safety and could lead to runtime errors. I've provided suggestions to address these points.

github-actions · 2025-07-21T20:02:03Z

Code Coverage Summary

Package	Lines	Statements	Functions	Branches
CLI	70.69%	70.69%	78.73%	80.7%
Core	73.59%	73.59%	77.47%	79.77%

CLI Package - Full Text Report

-------------------|---------|----------|---------|---------|-------------------
File               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-------------------|---------|----------|---------|---------|-------------------
All files          |   70.69 |     80.7 |   78.73 |   70.69 |                   
 src               |   42.82 |    55.55 |    37.5 |   42.82 |                   
  gemini.tsx       |   18.01 |     12.5 |   16.66 |   18.01 | ...57-274,279-353 
  ...ractiveCli.ts |   91.36 |    67.85 |     100 |   91.36 | ...43,146,169-170 
 src/acp           |    1.73 |        0 |       0 |    1.73 |                   
  acp.ts           |    2.79 |        0 |       0 |    2.79 | ...98-225,228-271 
  acpPeer.ts       |     1.4 |        0 |       0 |     1.4 | 33-48,51-674      
 src/config        |   88.68 |    81.68 |   87.09 |   88.68 |                   
  auth.ts          |     100 |      100 |     100 |     100 |                   
  config.ts        |   97.46 |    87.69 |      75 |   97.46 | ...30,274,453-457 
  extension.ts     |   81.96 |    84.37 |     100 |   81.96 | ...97-101,110-111 
  sandboxConfig.ts |   54.05 |       50 |   66.66 |   54.05 | ...43,53-69,74-91 
  settings.ts      |   87.22 |    79.72 |   92.85 |   87.22 | ...60-361,401-402 
 src/generated     |     100 |      100 |     100 |     100 |                   
  git-commit.ts    |     100 |      100 |     100 |     100 |                   
 src/services      |   98.76 |    91.66 |   83.33 |   98.76 |                   
  ...mandLoader.ts |     100 |      100 |     100 |     100 |                   
  ...andService.ts |     100 |      100 |     100 |     100 |                   
  types.ts         |       0 |        0 |       0 |       0 | 1                 
 src/test-utils    |     100 |      100 |     100 |     100 |                   
  ...andContext.ts |     100 |      100 |     100 |     100 |                   
 src/ui            |   59.46 |    67.07 |   71.42 |   59.46 |                   
  App.tsx          |   56.27 |    60.29 |    62.5 |   56.27 | ...04-915,938-967 
  colors.ts        |   86.04 |      100 |   76.92 |   86.04 | 12-13,18-19,42-43 
  constants.ts     |     100 |      100 |     100 |     100 |                   
  types.ts         |     100 |      100 |     100 |     100 |                   
 src/ui/commands   |   95.98 |    88.41 |     100 |   95.98 |                   
  aboutCommand.ts  |     100 |    55.55 |     100 |     100 | 23-30             
  authCommand.ts   |     100 |      100 |     100 |     100 |                   
  bugCommand.ts    |   78.46 |    42.85 |     100 |   78.46 | 32-35,72-81       
  chatCommand.ts   |      92 |    79.41 |     100 |      92 | ...75-176,178-179 
  clearCommand.ts  |     100 |      100 |     100 |     100 |                   
  ...essCommand.ts |     100 |    88.88 |     100 |     100 | 69                
  copyCommand.ts   |     100 |      100 |     100 |     100 |                   
  corgiCommand.ts  |     100 |      100 |     100 |     100 |                   
  docsCommand.ts   |     100 |      100 |     100 |     100 |                   
  editorCommand.ts |     100 |      100 |     100 |     100 |                   
  ...onsCommand.ts |     100 |      100 |     100 |     100 |                   
  helpCommand.ts   |     100 |      100 |     100 |     100 |                   
  ideCommand.ts    |   99.29 |    90.47 |     100 |   99.29 | 34                
  mcpCommand.ts    |   97.88 |    90.38 |     100 |   97.88 | 149-150,172-173   
  memoryCommand.ts |     100 |      100 |     100 |     100 |                   
  ...acyCommand.ts |     100 |      100 |     100 |     100 |                   
  quitCommand.ts   |     100 |      100 |     100 |     100 |                   
  ...oreCommand.ts |   93.79 |    91.42 |     100 |   93.79 | 54-55,84-89       
  statsCommand.ts  |   84.48 |       75 |     100 |   84.48 | 24-32             
  themeCommand.ts  |     100 |      100 |     100 |     100 |                   
  toolsCommand.ts  |     100 |      100 |     100 |     100 |                   
  types.ts         |     100 |      100 |     100 |     100 |                   
 src/ui/components |   63.22 |     78.3 |   64.86 |   63.22 |                   
  AboutBox.tsx     |     100 |       50 |     100 |     100 | 102               
  AsciiArt.ts      |     100 |      100 |     100 |     100 |                   
  AuthDialog.tsx   |   89.78 |    96.42 |   66.66 |   89.78 | 68-73,102-109     
  ...nProgress.tsx |   15.78 |      100 |       0 |   15.78 | 17-57             
  ...Indicator.tsx |   15.15 |      100 |       0 |   15.15 | 17-47             
  ...ryDisplay.tsx |   21.05 |      100 |       0 |   21.05 | 17-35             
  ...ryDisplay.tsx |   91.02 |    94.59 |     100 |   91.02 | 73-78,98          
  ...esDisplay.tsx |   10.52 |      100 |       0 |   10.52 | 24-82             
  ...ngsDialog.tsx |    6.76 |      100 |       0 |    6.76 | 26-168            
  Footer.tsx       |   67.44 |       10 |     100 |   67.44 | ...02-109,112-115 
  ...ngSpinner.tsx |      80 |    33.33 |     100 |      80 | 29,31-32          
  Header.tsx       |   17.07 |      100 |       0 |   17.07 | 22-63             
  Help.tsx         |    3.73 |      100 |       0 |    3.73 | 17-154            
  ...emDisplay.tsx |   68.65 |       50 |     100 |   68.65 | ...55-60,79-86,89 
  InputPrompt.tsx  |   82.51 |    73.07 |     100 |   82.51 | ...52,497,525-529 
  ...Indicator.tsx |     100 |      100 |     100 |     100 |                   
  ...geDisplay.tsx |   25.92 |      100 |       0 |   25.92 | 14-36             
  ...tsDisplay.tsx |     100 |      100 |     100 |     100 |                   
  ...ryDisplay.tsx |     100 |      100 |     100 |     100 |                   
  ...Indicator.tsx |   44.44 |      100 |       0 |   44.44 | 12-17             
  ...MoreLines.tsx |      60 |       25 |     100 |      60 | 24-27,33-40       
  StatsDisplay.tsx |   98.39 |    86.66 |     100 |   98.39 | 173-175           
  ...nsDisplay.tsx |   83.05 |    61.53 |     100 |   83.05 | 34-39,42-43,87-89 
  ThemeDialog.tsx  |    4.29 |      100 |       0 |    4.29 | 29-311            
  Tips.tsx         |      16 |      100 |       0 |      16 | 17-45             
  ...tsDisplay.tsx |     100 |     87.5 |     100 |     100 | 30-31             
  ...ification.tsx |   36.36 |      100 |       0 |   36.36 | 15-22             
 ...nents/messages |   61.01 |    78.89 |   52.63 |   61.01 |                   
  ...onMessage.tsx |   18.51 |      100 |       0 |   18.51 | 22-49             
  DiffRenderer.tsx |   96.37 |       80 |     100 |   96.37 | ...06-207,211,276 
  ErrorMessage.tsx |   22.22 |      100 |       0 |   22.22 | 16-31             
  ...niMessage.tsx |   18.51 |      100 |       0 |   18.51 | 20-43             
  ...geContent.tsx |   19.04 |      100 |       0 |   19.04 | 25-43             
  InfoMessage.tsx  |   22.22 |      100 |       0 |   22.22 | 16-31             
  ...onMessage.tsx |   38.91 |     62.5 |   33.33 |   38.91 | ...32-164,200-225 
  ...upMessage.tsx |   10.11 |      100 |       0 |   10.11 | 27-126            
  ToolMessage.tsx  |   87.76 |       80 |     100 |   87.76 | ...,91-95,169-171 
  UserMessage.tsx  |     100 |      100 |     100 |     100 |                   
  ...llMessage.tsx |   36.36 |      100 |       0 |   36.36 | 17-25             
 ...ponents/shared |   74.08 |    71.42 |   91.66 |   74.08 |                   
  MaxSizedBox.tsx  |   80.66 |    81.19 |   88.88 |   80.66 | ...08-509,614-615 
  ...tonSelect.tsx |   66.66 |    65.51 |     100 |   66.66 | ...15,119-155,224 
  text-buffer.ts   |   72.44 |    67.24 |    92.3 |   72.44 | ...1235-1238,1243 
 src/ui/contexts   |   90.57 |    86.36 |     100 |   90.57 |                   
  ...owContext.tsx |   91.07 |    81.81 |     100 |   91.07 | 46-47,59-61       
  ...onContext.tsx |   94.11 |      100 |     100 |   94.11 | 101-104           
  ...ngContext.tsx |   71.42 |       50 |     100 |   71.42 | 17-20             
 src/ui/editors    |   93.87 |    85.71 |   66.66 |   93.87 |                   
  ...ngsManager.ts |   93.87 |    85.71 |   66.66 |   93.87 | 53,67-68          
 src/ui/hooks      |   75.37 |    82.82 |   77.58 |   75.37 |                   
  ...dProcessor.ts |   83.19 |     83.5 |     100 |   83.19 | ...37-440,451-467 
  ...dProcessor.ts |   83.51 |    74.35 |      80 |   83.51 | ...46-355,359-360 
  ...dProcessor.ts |   77.51 |    60.37 |     100 |   77.51 | ...71-275,294-296 
  ...uthCommand.ts |    7.46 |      100 |       0 |    7.46 | 19-93             
  ...tIndicator.ts |     100 |      100 |     100 |     100 |                   
  ...ketedPaste.ts |     100 |      100 |     100 |     100 |                   
  useCompletion.ts |    78.8 |       90 |      80 |    78.8 | ...40-446,523-526 
  ...leMessages.ts |   96.96 |    88.88 |     100 |   96.96 | 25-26             
  ...orSettings.ts |     100 |      100 |     100 |     100 |                   
  useFocus.ts      |     100 |      100 |     100 |     100 |                   
  ...miniStream.ts |   67.53 |    70.22 |     100 |   67.53 | ...55-756,786-876 
  ...BranchName.ts |   91.66 |    84.61 |     100 |   91.66 | 57-63             
  ...oryManager.ts |   98.41 |    93.33 |     100 |   98.41 | 43                
  ...putHistory.ts |    92.5 |    85.71 |     100 |    92.5 | 62-63,71,93-95    
  useKeypress.ts   |     100 |      100 |     100 |     100 |                   
  ...gIndicator.ts |     100 |      100 |     100 |     100 |                   
  useLogger.ts     |      25 |      100 |       0 |      25 | 14-32             
  ...raseCycler.ts |    95.5 |       75 |     100 |    95.5 | ...66-167,185-187 
  ...cySettings.ts |     3.6 |      100 |       0 |     3.6 | 18-139            
  ...lScheduler.ts |   79.01 |    94.87 |     100 |   79.01 | ...00-203,293-303 
  ...oryCommand.ts |       0 |        0 |       0 |       0 | 1-7               
  ...ellHistory.ts |   91.95 |    79.16 |   83.33 |   91.95 | 28-30,41-42,87-88 
  ...oryCommand.ts |       0 |        0 |       0 |       0 | 1-75              
  ...tateAndRef.ts |   59.09 |      100 |     100 |   59.09 | 23-31             
  ...rminalSize.ts |   77.27 |      100 |      50 |   77.27 | 19-23             
  ...emeCommand.ts |   46.98 |       75 |     100 |   46.98 | ...4,70-71,77-100 
  useTimer.ts      |   88.09 |    85.71 |     100 |   88.09 | 44-45,51-53       
 src/ui/privacy    |   13.77 |      100 |       0 |   13.77 |                   
  ...acyNotice.tsx |    9.58 |      100 |       0 |    9.58 | 20-113            
  ...acyNotice.tsx |    12.9 |      100 |       0 |    12.9 | 15-55             
  ...acyNotice.tsx |   10.81 |      100 |       0 |   10.81 | 15-58             
  ...acyNotice.tsx |   30.76 |      100 |       0 |   30.76 | 19-36,39-41       
 src/ui/themes     |    99.2 |    89.87 |     100 |    99.2 |                   
  ansi-light.ts    |     100 |      100 |     100 |     100 |                   
  ansi.ts          |     100 |      100 |     100 |     100 |                   
  atom-one-dark.ts |     100 |      100 |     100 |     100 |                   
  ayu-light.ts     |     100 |      100 |     100 |     100 |                   
  ayu.ts           |     100 |      100 |     100 |     100 |                   
  color-utils.ts   |     100 |      100 |     100 |     100 |                   
  default-light.ts |     100 |      100 |     100 |     100 |                   
  default.ts       |     100 |      100 |     100 |     100 |                   
  dracula.ts       |     100 |      100 |     100 |     100 |                   
  github-dark.ts   |     100 |      100 |     100 |     100 |                   
  github-light.ts  |     100 |      100 |     100 |     100 |                   
  googlecode.ts    |     100 |      100 |     100 |     100 |                   
  no-color.ts      |     100 |      100 |     100 |     100 |                   
  ...-of-purple.ts |     100 |      100 |     100 |     100 |                   
  theme-manager.ts |    93.1 |    84.61 |     100 |    93.1 | ...72,176,201-202 
  theme.ts         |   96.45 |     91.3 |     100 |   96.45 | 337-341,371-375   
  xcode.ts         |     100 |      100 |     100 |     100 |                   
 src/ui/utils      |   75.67 |    88.53 |   94.23 |   75.67 |                   
  ...Colorizer.tsx |   74.78 |    79.16 |     100 |   74.78 | ...20-123,160-184 
  ...olePatcher.ts |   60.97 |      100 |   66.66 |   60.97 | 35-39,49-60       
  ...nRenderer.tsx |   26.51 |       75 |     100 |   26.51 | 32-137            
  ...wnDisplay.tsx |   86.19 |    87.69 |     100 |   86.19 | ...71-279,311-332 
  ...eRenderer.tsx |   78.09 |    76.19 |     100 |   78.09 | 55-83             
  ...boardUtils.ts |   32.25 |     37.5 |     100 |   32.25 | ...55-114,129-145 
  commandUtils.ts  |   96.36 |    90.47 |     100 |   96.36 | 68,72             
  computeStats.ts  |     100 |      100 |     100 |     100 |                   
  displayUtils.ts  |     100 |      100 |     100 |     100 |                   
  errorParsing.ts  |     100 |     92.5 |     100 |     100 | 74,78,84          
  formatters.ts    |   90.47 |    95.83 |     100 |   90.47 | 57-60             
  ...nUtilities.ts |   69.84 |    85.71 |     100 |   69.84 | 75-91,100-101     
  textUtils.ts     |   81.81 |      100 |      80 |   81.81 | 13-18             
  updateCheck.ts   |     100 |      100 |     100 |     100 |                   
 src/utils         |   11.24 |       80 |   63.63 |   11.24 |                   
  cleanup.ts       |      64 |    66.66 |   66.66 |      64 | 18-26,35          
  package.ts       |   88.88 |    85.71 |     100 |   88.88 | 33-34             
  readStdin.ts     |    3.44 |      100 |       0 |    3.44 | 7-39              
  sandbox.ts       |       0 |        0 |       0 |       0 | 1-871             
  ...upWarnings.ts |   23.07 |      100 |       0 |   23.07 | 14-40             
  ...upWarnings.ts |   95.91 |    91.66 |     100 |   95.91 | 51-52             
  version.ts       |     100 |       50 |     100 |     100 | 11                
-------------------|---------|----------|---------|---------|-------------------

Core Package - Full Text Report

-------------------|---------|----------|---------|---------|-------------------
File               | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-------------------|---------|----------|---------|---------|-------------------
All files          |   73.59 |    79.77 |   77.47 |   73.59 |                   
 src               |     100 |      100 |     100 |     100 |                   
  index.ts         |     100 |      100 |     100 |     100 |                   
 src/__mocks__/fs  |     100 |      100 |     100 |     100 |                   
  promises.ts      |     100 |      100 |     100 |     100 |                   
 src/code_assist   |   69.78 |    74.25 |   71.05 |   69.78 |                   
  codeAssist.ts    |   18.51 |      100 |       0 |   18.51 | 13-35             
  converter.ts     |   89.06 |    96.15 |   81.81 |   89.06 | 176-180,199-209   
  oauth2.ts        |   75.16 |    63.04 |      80 |   75.16 | ...80-381,393-399 
  server.ts        |   46.75 |       80 |   53.84 |   46.75 | ...61-202,205-207 
  setup.ts         |   73.77 |     62.5 |     100 |   73.77 | 57-58,69-71,83-93 
  types.ts         |     100 |      100 |     100 |     100 |                   
 src/config        |   81.49 |    85.18 |   62.12 |   81.49 |                   
  config.ts        |   81.32 |    85.18 |   62.12 |   81.32 | ...93-600,606-607 
  models.ts        |     100 |      100 |     100 |     100 |                   
 src/core          |    73.2 |    75.59 |   78.72 |    73.2 |                   
  client.ts        |   71.78 |    75.26 |      80 |   71.78 | ...84,686-687,690 
  ...tGenerator.ts |   91.95 |    78.26 |     100 |   91.95 | 79-80,132,143-146 
  ...lScheduler.ts |   72.77 |    70.51 |   81.25 |   72.77 | ...68-674,691-700 
  geminiChat.ts    |   62.85 |    71.79 |   64.28 |   62.85 | ...17,632,636-644 
  geminiRequest.ts |     100 |      100 |     100 |     100 |                   
  logger.ts        |   82.71 |    78.26 |     100 |   82.71 | ...72-276,285-286 
  modelCheck.ts    |   23.52 |       50 |     100 |   23.52 | 31-75             
  ...olExecutor.ts |     100 |    66.66 |     100 |     100 | 64,99             
  prompts.ts       |   81.25 |    68.18 |      50 |   81.25 | ...61-266,282-339 
  tokenLimits.ts   |      15 |      100 |       0 |      15 | 15-31             
  turn.ts          |   82.03 |    82.14 |     100 |   82.03 | ...32-235,248-249 
 src/mcp           |    73.3 |       79 |   89.65 |    73.3 |                   
  ...h-provider.ts |   77.75 |    67.24 |      90 |   77.75 | ...14-616,621-623 
  ...en-storage.ts |     100 |      100 |     100 |     100 |                   
  oauth-utils.ts   |   42.85 |     87.5 |      80 |   42.85 | ...32-192,216-252 
 src/services      |   93.28 |    91.01 |   88.57 |   93.28 |                   
  ...eryService.ts |      96 |    85.18 |     100 |      96 | 31,39,84          
  gitService.ts    |   77.52 |      100 |      60 |   77.52 | ...08-112,115-119 
  ideContext.ts    |     100 |      100 |     100 |     100 |                   
  ...ionService.ts |    97.8 |       90 |     100 |    97.8 | 149-150,160-161   
 src/telemetry     |   71.09 |    83.72 |   82.69 |   71.09 |                   
  constants.ts     |     100 |      100 |     100 |     100 |                   
  index.ts         |     100 |      100 |     100 |     100 |                   
  ...t.circular.ts |       0 |        0 |       0 |       0 | 1-62              
  ...t.circular.ts |       0 |        0 |       0 |       0 | 1-119             
  loggers.ts       |   79.13 |    81.81 |      80 |   79.13 | 186-225,294-311   
  metrics.ts       |   60.36 |    95.65 |    62.5 |   60.36 | ...36-158,161-184 
  sdk.ts           |   82.85 |    28.57 |     100 |   82.85 | ...18,126-127,133 
  types.ts         |   83.62 |    93.61 |   88.23 |   83.62 | 83-92,162-191     
  uiTelemetry.ts   |   99.23 |       95 |     100 |   99.23 | 119               
 ...learcut-logger |    83.5 |    74.41 |      75 |    83.5 |                   
  ...cut-logger.ts |   83.37 |     73.8 |   78.94 |   83.37 | ...18-519,523-525 
  ...tadata-key.ts |   84.61 |      100 |       0 |   84.61 | 169-179           
 src/tools         |   65.17 |    78.22 |   70.21 |   65.17 |                   
  diffOptions.ts   |     100 |      100 |     100 |     100 |                   
  edit.ts          |   77.55 |    82.85 |      75 |   77.55 | ...49-450,454-489 
  glob.ts          |   85.29 |    80.95 |   83.33 |   85.29 | ...68-269,277-284 
  grep.ts          |   57.35 |     75.8 |   72.72 |   57.35 | ...32-537,542-546 
  ls.ts            |    8.61 |      100 |   14.28 |    8.61 | ...74-179,187-326 
  mcp-client.ts    |   44.88 |    74.19 |   30.76 |   44.88 | ...17-421,425-428 
  mcp-tool.ts      |   84.92 |     87.5 |      90 |   84.92 | ...69,175,180-181 
  memoryTool.ts    |   97.46 |    84.84 |     100 |   97.46 | 94,96,98-99       
  ...iable-tool.ts |     100 |    84.61 |     100 |     100 | 90,97             
  read-file.ts     |   96.69 |    96.15 |   83.33 |   96.69 | 113-114,123-124   
  ...many-files.ts |   82.85 |    69.23 |      80 |   82.85 | ...90-491,498-499 
  shell.ts         |    65.8 |    66.12 |   78.57 |    65.8 | ...56,473,479-491 
  tool-registry.ts |    58.7 |       75 |   85.71 |    58.7 | ...93-295,305-310 
  tools.ts         |   75.47 |      100 |   33.33 |   75.47 | ...67-172,181-184 
  web-fetch.ts     |   31.06 |    68.42 |   66.66 |   31.06 | ...92-193,221-359 
  web-search.ts    |   26.72 |      100 |      40 |   26.72 | ...04-105,108-197 
  write-file.ts    |   81.45 |    83.67 |   77.77 |   81.45 | ...09-314,376-406 
 src/utils         |   80.54 |    81.97 |    87.5 |   80.54 |                   
  LruCache.ts      |   70.96 |     62.5 |     100 |   70.96 | 20-22,28,30-34    
  bfsFileSearch.ts |   93.22 |    88.23 |     100 |   93.22 | 54-55,68-69       
  browser.ts       |    8.69 |      100 |       0 |    8.69 | 17-53             
  editCorrector.ts |   77.35 |    61.11 |   91.66 |   77.35 | ...70-682,716,730 
  editor.ts        |    97.4 |    94.11 |     100 |    97.4 | 145,207,210-211   
  ...rReporting.ts |   83.52 |    84.61 |     100 |   83.52 | 81-85,106-114     
  errors.ts        |   39.02 |       60 |      75 |   39.02 | 21-25,41-57,61-67 
  fetch.ts         |   34.04 |      100 |       0 |   34.04 | 22-27,31-57       
  fileUtils.ts     |    93.1 |    88.31 |     100 |    93.1 | ...66-270,339-345 
  ...eUtilities.ts |   96.03 |       96 |     100 |   96.03 | 28-29,57-58       
  ...rStructure.ts |   96.06 |    94.87 |     100 |   96.06 | ...14-117,354-356 
  ...noreParser.ts |   96.66 |       92 |     100 |   96.66 | 75-76             
  gitUtils.ts      |   46.34 |    66.66 |      50 |   46.34 | 24-25,40-41,50-73 
  ...yDiscovery.ts |   81.36 |    75.43 |      75 |   81.36 | ...27-328,331-332 
  ...tProcessor.ts |   86.86 |    88.46 |     100 |   86.86 | 115-124,131-140   
  ...Inspectors.ts |     100 |      100 |     100 |     100 |                   
  ...kerChecker.ts |   83.51 |    83.33 |     100 |   83.51 | ...95-100,108-114 
  paths.ts         |   63.21 |    73.33 |   57.14 |   63.21 | ...24-134,140-141 
  ...rDetection.ts |   37.28 |    36.36 |      80 |   37.28 | ...7,91-92,98-103 
  retry.ts         |   62.55 |    73.21 |     100 |   62.55 | ...54-274,319-334 
  ...nStringify.ts |     100 |      100 |     100 |     100 |                   
  ...aValidator.ts |   86.95 |    68.75 |     100 |   86.95 | 24-25,27-28,45-46 
  session.ts       |     100 |      100 |     100 |     100 |                   
  summarizer.ts    |      92 |       75 |     100 |      92 | 46-47,57-58,74-75 
  testUtils.ts     |   84.44 |    72.72 |   83.33 |   84.44 | 27-28,34-35,70-72 
  user_account.ts  |   97.72 |    97.05 |     100 |   97.72 | 102-103           
  user_id.ts       |   60.97 |    44.44 |      75 |   60.97 | ...33,46-48,52-57 
-------------------|---------|----------|---------|---------|-------------------

For detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run.

jacob314

scidomino requested a review from a team as a code owner July 21, 2025 19:58

gemini-code-assist Bot reviewed Jul 21, 2025

View reviewed changes

Comment thread packages/core/src/code_assist/server.ts Outdated

Comment thread packages/core/src/core/client.ts Outdated

gemini-cli Bot added kind/bug priority/p0 Critical and urgent (e.g., critical security vulnerability, major breakage). labels Jul 21, 2025

jacob314 approved these changes Jul 21, 2025

View reviewed changes

Simplify streaming code for code assist server.

5cf1415

scidomino force-pushed the tomm_fix branch from a76ecee to 5cf1415 Compare July 21, 2025 20:40

scidomino enabled auto-merge July 21, 2025 20:41

Merge branch 'main' into tomm_fix

d019983

scidomino added this pull request to the merge queue Jul 21, 2025

Merged via the queue into main with commit d7a57d8 Jul 21, 2025
10 checks passed

scidomino deleted the tomm_fix branch July 21, 2025 20:48

thacio added a commit to thacio/auditaria that referenced this pull request Jul 22, 2025

Simplify streaming code for code assist server (google-gemini#4619)

7896011

galdawave pushed a commit that referenced this pull request Jul 22, 2025

Simplify streaming code for code assist server (#4619)

4b3e275

jkcinouye pushed a commit that referenced this pull request Jul 25, 2025

Simplify streaming code for code assist server (#4619)

caf7e20

JunYang-tes pushed a commit to JunYang-tes/gemini-cli.nvim that referenced this pull request Aug 9, 2025

Simplify streaming code for code assist server (google-gemini#4619)

5c3dd5c

frikyfriky11 mentioned this pull request Aug 13, 2025

Inconsistent Release Changelog Generation: 'Full Changelog' always starts from v0.1.12 #5663

Closed

involvex pushed a commit to involvex/gemini-cli that referenced this pull request Sep 11, 2025

Simplify streaming code for code assist server (google-gemini#4619)

dd9dd66

reconsumeralization pushed a commit to reconsumeralization/gemini-cli that referenced this pull request Sep 19, 2025

Simplify streaming code for code assist server (google-gemini#4619)

0ba2e4a

sripasg added the size/m A medium sized PR label Jun 2, 2026

Navigation Menu

Uh oh!

Simplify streaming code for code assist server - #4619

Simplify streaming code for code assist server#4619
scidomino merged 2 commits into
mainfrom
tomm_fix

scidomino commented Jul 21, 2025 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

jacob314 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

scidomino commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

Reviewer Test Plan

Testing Matrix

Linked issues / bugs

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

jacob314 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

scidomino commented Jul 21, 2025 •

edited

Loading

github-actions Bot commented Jul 21, 2025 •

edited

Loading