Update Terms of Service and Privacy Notice for clarity. - #3036
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @jkcinouye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the clarity and comprehensiveness of the Gemini CLI's Terms of Service and Privacy Notice documentation. The changes aim to provide users with a more intuitive understanding of which policies apply based on their authentication method and account type, particularly concerning data collection and usage.
Highlights
- Document Restructuring: The
docs/tos-privacy.mdfile has been significantly restructured to improve readability and clarity. The previous numbered sections for authentication methods have been replaced with a new introductory section outlining how to determine the authentication method, followed by detailed sections for each method. - Authentication Method Summary Table: A new comprehensive table has been added to the document, providing a quick reference for all four authentication methods, associated account types, and their respective Terms of Service and Privacy Notice links. This centralizes key information for easier access.
- Clarified Data Usage Policies: The Frequently Asked Questions (FAQ) section, particularly the question regarding whether code, prompts, and answers are used to train Google's models, has been extensively rewritten. It now provides explicit, detailed answers for each of the four authentication methods, making it much clearer under which conditions data is collected or not.
- Enhanced Usage Statistics Explanation: The explanation of 'Usage Statistics' and its opt-out control has been expanded and clarified. Similar to the data usage FAQ, it now explicitly details what data is collected for each authentication and account type when usage statistics are enabled or disabled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request significantly improves the clarity and organization of the Terms of Service and Privacy Notice documentation. The restructuring of the content, addition of a summary table, and more explicit language in the FAQ make it much easier for users to understand which policies apply to their specific authentication method and account type. I have reviewed the changes for correctness and clarity and found no high or critical severity issues. The updates are a valuable improvement to the user documentation.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-20.x' artifact from the main CI run. |
TLDR
Updates the existing Terms of Service and Privacy Notice for clarity.
Dive Deeper
Updates the existing Terms of Service and Privacy Notice to make it clearer which authentication methods and which accounts are associated with which policies.
Reviewer Test Plan
Testing Matrix
Linked issues / bugs