Skip to content

fix(ci): prevent workspace binary shadowing in release verification #28132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galdawave merged 1 commit into from
Jun 24, 2026
Merged

fix(ci): prevent workspace binary shadowing in release verification #28132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/verify-release/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,6 @@ runs:
# See https://github.com/google-gemini/gemini-cli/issues/10517
CI: 'false'
shell: 'bash'
run: 'npm run test:integration:sandbox:none'
run: |
export INTEGRATION_TEST_GEMINI_BINARY_PATH=$(which gemini)
npm run test:integration:sandbox:none
Comment on lines +102 to +103

@gemini-code-assist gemini-code-assist Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In bash, combining export with a command substitution (e.g., export VAR=$(command)) masks the exit code of the command. If which gemini fails, the export command will still return 0, causing the script to continue executing the integration tests with an empty or invalid binary path instead of failing immediately under set -e.

Additionally, using command -v is more portable and robust than which across different environments.

To ensure the CI step fails immediately if the binary cannot be resolved, separate the assignment from the export statement and use command -v with proper double-quoting.

        INTEGRATION_TEST_GEMINI_BINARY_PATH="$(command -v gemini)"
        export INTEGRATION_TEST_GEMINI_BINARY_PATH
        npm run test:integration:sandbox:none

Loading