fix(core): handle EBADF error when resizing a closed PTY

[anexoluiz]

This PR fixes a crash in the Gemini CLI that occurs when attempting to resize a PTY that has already been closed. This is a common race condition in environment with tiled window managers or terminal multiplexers like Zellij, where rapid layout changes can trigger a resize event exactly as a process terminates, leading to an Error: ioctl(2) failed, EBADF.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a crash in the Gemini CLI that occurs when a PTY resize event is triggered for a terminal that has already been closed. By correctly identifying the EBADF error, the service can now handle these events gracefully, improving the stability of the terminal interface in environments with rapid layout changes.

Highlights

• Error Handling: Added explicit handling for EBADF errors during PTY resizing to prevent application crashes caused by race conditions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request attempts to add a check for the 'EBADF' error code in shellExecutionService.ts. However, it introduces a duplicate declaration of the block-scoped variable isEbadf, which will cause a compilation error. The reviewer correctly identified this issue and provided a suggestion to remove the redundant line.

[anexoluiz]

/gemini review

[gemini-code-assist]

Code Review

This pull request removes the unused isEbadf error check from the ShellExecutionService class in packages/core/src/services/shellExecutionService.ts. I have no feedback to provide as there are no review comments.

[anexoluiz]

Fixes #27528 @gemini-code-assist

[anexoluiz]

Fixes #27528. This PR fixes the PTY resize race condition.

[anexoluiz]

Closing this as I see #27461 has already addressed the issue in main.