Skip to content

fix(ide/process-utils): spawn powershell.exe with -NoProfile -NonInteractive #27241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaluchi wants to merge 1 commit into from
Closed

fix(ide/process-utils): spawn powershell.exe with -NoProfile -NonInteractive #27241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 38 additions & 4 deletions packages/core/src/ide/process-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,15 @@ describe('getIdeProcessInfo', () => {
command: 'C:\\Program Files\\VSCode\\Code.exe',
});
expect(mockedExec).toHaveBeenCalledWith(
expect.stringContaining(
'Get-CimInstance Win32_Process | Select-Object ProcessId,ParentProcessId,Name,CommandLine',
),
'powershell.exe',
expect.arrayContaining([
'-NoProfile',
'-NonInteractive',
'-Command',
expect.stringContaining(
'Get-CimInstance Win32_Process | Select-Object ProcessId,ParentProcessId,Name,CommandLine',
),
]),
expect.anything(),
);
});
Expand Down Expand Up @@ -142,11 +148,39 @@ describe('getIdeProcessInfo', () => {
const result = await getIdeProcessInfo();
expect(result).toEqual({ pid: 900, command: 'powershell.exe' });
expect(mockedExec).toHaveBeenCalledWith(
expect.stringContaining('Get-CimInstance Win32_Process'),
'powershell.exe',
expect.arrayContaining([
'-NoProfile',
'-NonInteractive',
'-Command',
expect.stringContaining('Get-CimInstance Win32_Process'),
]),
expect.anything(),
);
});

it('should invoke powershell.exe with -NoProfile -NonInteractive flags', async () => {
(os.platform as Mock).mockReturnValue('win32');
const processes = [
{
ProcessId: 1000,
ParentProcessId: 0,
Name: 'node.exe',
CommandLine: 'node.exe',
},
];
mockedExec.mockResolvedValueOnce({ stdout: JSON.stringify(processes) });

await getIdeProcessInfo();

expect(mockedExec).toHaveBeenCalledTimes(1);
const [program, args] = mockedExec.mock.calls[0];
expect(program).toBe('powershell.exe');
expect(args).toContain('-NoProfile');
expect(args).toContain('-NonInteractive');
expect(args).toContain('-Command');
});

it('should handle short process chains', async () => {
(os.platform as Mock).mockReturnValue('win32');
// process (1000) -> root (0)
Expand Down
13 changes: 9 additions & 4 deletions packages/core/src/ide/process-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { exec } from 'node:child_process';
import { exec, execFile } from 'node:child_process';
import { promisify } from 'node:util';
import os from 'node:os';
import path from 'node:path';

const execAsync = promisify(exec);
const execFileAsync = promisify(execFile);

const MAX_TRAVERSAL_DEPTH = 32;

Expand Down Expand Up @@ -37,9 +38,13 @@ async function getProcessTableWindows(): Promise<Map<number, ProcessInfo>> {
const powershellCommand =
'Get-CimInstance Win32_Process | Select-Object ProcessId,ParentProcessId,Name,CommandLine | ConvertTo-Json -Compress';
// Increase maxBuffer to handle large process lists (default is 1MB)
const { stdout } = await execAsync(`powershell "${powershellCommand}"`, {
maxBuffer: 10 * 1024 * 1024,
});
const { stdout } = await execFileAsync(
'powershell.exe',
['-NoProfile', '-NonInteractive', '-Command', powershellCommand],
{
maxBuffer: 10 * 1024 * 1024,
},
);

if (!stdout.trim()) {
return processMap;
Expand Down