Skip to content

fix(core): ensure Vertex AI sets hasAccessToPreviewModels and remove aggressive 404 fallback revocation #27067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
galdawave merged 2 commits into from
May 14, 2026
Merged

fix(core): ensure Vertex AI sets hasAccessToPreviewModels and remove aggressive 404 fallback revocation #27067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f8be6b
git commit -m "fix(core): ensure Vertex AI sets hasAccessToPreviewMod…
galdawave May 14, 2026
87732d5
Merge branch 'main' into galzahavi/fix/vertex-utility-calls
galdawave May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1627,7 +1627,10 @@ export class Config implements McpContext, AgentLoopContext {
this.baseLlmClient = new BaseLlmClient(this.contentGenerator, this);

const authType = this.contentGeneratorConfig.authType;
if (authType === AuthType.USE_GEMINI) {
if (
authType === AuthType.USE_GEMINI ||
authType === AuthType.USE_VERTEX_AI
) {
Comment on lines +1630 to +1633

@gemini-code-assist gemini-code-assist Bot May 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current logic for setting hasAccessToPreviewModel to true is becoming repetitive and currently misses AuthType.GATEWAY, which is treated as a 'launched' auth type elsewhere in this file (see isGemini31LaunchedForAuthType at line 3498). Using the existing private helper isGemini31LaunchedForAuthType would improve maintainability and ensure consistency across all relevant authentication types, including Gateway users who should also have preview access by default.

    if (this.isGemini31LaunchedForAuthType(authType)) {
References
  1. Avoid overlapping checks in model resolution logic by relying on condensed sources of truth to ensure consistency and reduce logic duplication.

this.setHasAccessToPreviewModel(true);
}

Expand Down
7 changes: 0 additions & 7 deletions packages/core/src/fallback/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import {
applyAvailabilityTransition,
} from '../availability/policyHelpers.js';

import { isPreviewModel } from '../config/models.js';

export const UPGRADE_URL_PAGE = 'https://goo.gle/set-up-gemini-code-assist';

export async function handleFallback(
Expand All @@ -32,11 +30,6 @@ export async function handleFallback(
): Promise<string | boolean | null> {
const failureKind = classifyFailureKind(error);

// If a preview model is not found, record that the user lacks preview access.
if (failureKind === 'not_found' && isPreviewModel(failedModel, config)) {
config.setHasAccessToPreviewModel?.(false);
}

const chain = resolvePolicyChain(config);
const { failedPolicy, candidates } = buildFallbackPolicyContext(
chain,
Expand Down
Loading