Skip to content

fix(ux): fixed issue with transcribed text not showing after releasing space #26609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devr0306 merged 7 commits into from
May 7, 2026
Merged

fix(ux): fixed issue with transcribed text not showing after releasing space #26609

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fc18d42
Fixed issue with transcribed text not showing after releasing space
devr0306 May 6, 2026
4480f66
Merge branch 'main' into voice-latency
devr0306 May 7, 2026
72fc1e7
chore: run specific voice mode tests in CI
devr0306 May 7, 2026
6bc7d68
Comments and test fixes
devr0306 May 7, 2026
59f9ee1
Reverted ci file
devr0306 May 7, 2026
5071e46
Updated settings docs
devr0306 May 7, 2026
e420f42
Reverted unnecessary changes
devr0306 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions packages/cli/src/ui/hooks/useVoiceMode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,10 @@ export function useVoiceMode({
}

const serviceToDisconnect = transcriptionServiceRef.current;
transcriptionServiceRef.current = null;

if (serviceToDisconnect) {
const isLive = settings.experimental.voice?.backend === 'gemini-live';
const gracePeriodMs =
settings.experimental.voice?.stopGracePeriodMs ??
(isLive ? 2000 : 1000);
const gracePeriodMs = isLive ? 4000 : 3000;
Comment thread
devr0306 marked this conversation as resolved.
Outdated
debugLogger.debug(
`[Voice] Draining transcription for ${gracePeriodMs}ms`,
);
Expand All @@ -90,11 +87,16 @@ export function useVoiceMode({
disconnectTimerRef.current = setTimeout(() => {
debugLogger.debug('[Voice] Grace period ended, disconnecting service');
serviceToDisconnect.disconnect();
if (transcriptionServiceRef.current === serviceToDisconnect) {
transcriptionServiceRef.current = null;
}
disconnectTimerRef.current = null;
liveTranscriptionRef.current = '';
}, gracePeriodMs);
} else {
liveTranscriptionRef.current = '';
}

liveTranscriptionRef.current = '';
pttStateRef.current = 'idle';
}, [settings.experimental.voice]);

Expand Down Expand Up @@ -186,10 +188,7 @@ export function useVoiceMode({
transcriptionServiceRef.current = currentService;

currentService.on('transcription', (text) => {
if (
transcriptionServiceRef.current !== currentService &&
stopRequestedRef.current
) {
if (transcriptionServiceRef.current !== currentService) {
// If this is an orphaned service that was replaced by a new session, ignore its events
return;
}
Expand Down Expand Up @@ -217,11 +216,7 @@ export function useVoiceMode({
});

currentService.on('turnComplete', () => {
if (
transcriptionServiceRef.current !== currentService &&
stopRequestedRef.current
)
return;
if (transcriptionServiceRef.current !== currentService) return;
// Advance the baseline so subsequent turns append after this turn's text
turnBaselineRef.current = bufferRef.current.text;
turnBaselineCursorOffsetRef.current = bufferRef.current.getOffset();
Expand Down
Loading