Skip to content

fix(core): handle ENAMETOOLONG in robustRealpath - #26401

Closed
senutpal wants to merge 1 commit into
google-gemini:mainfrom
senutpal:fix/enametoolong-paste-crash
Closed

fix(core): handle ENAMETOOLONG in robustRealpath#26401
senutpal wants to merge 1 commit into
google-gemini:mainfrom
senutpal:fix/enametoolong-paste-crash

Conversation

@senutpal

@senutpal senutpal commented May 3, 2026

Copy link
Copy Markdown

summary

catches ENAMETOOLONG in robustRealpath alongside ENOENT/EISDIR. prevents the unhandled rejection on long pasted @-tokens.

why

parseAllAtCommands extracts a long token from a paste and feeds it through resolveToRealPath then robustRealpath. the leaf trips ENAMETOOLONG; the existing catch only matched ENOENT/EISDIR, so the error escaped the unguarded await checkPermissions(...) in AppContainer.tsx as an unhandled rejection.

mirrors 41f1ea467 (EISDIR). the parent-recursion fallback returns the input unchanged for single-segment leaves, so validatePathAccess drops it and the blob falls through as plain text.

tests

  • paths.test.ts: ENAMETOOLONG cases mirroring the EISDIR pattern
  • atCommandProcessor.test.ts: long-paste integration coverage

closes #26368

pasting a long string containing @ ends up in resolveToRealPath via
parseAllAtCommands, and the leaf trips ENAMETOOLONG. the catch only
matched ENOENT/EISDIR, so it escaped the unguarded await in
AppContainer as an unhandled rejection.

extend the catch list, same shape as 41f1ea4.

closes google-gemini#26368
@senutpal
senutpal requested a review from a team as a code owner May 3, 2026 11:26
@google-cla

google-cla Bot commented May 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a stability issue where pasting long strings containing unescaped '@' tokens caused the CLI to crash due to an unhandled promise rejection. By extending the error handling in the path resolution logic to include ENAMETOOLONG, the system now gracefully handles these cases, allowing the application to continue functioning as expected.

Highlights

  • Error Handling: Updated robustRealpath to catch ENAMETOOLONG errors, preventing unhandled promise rejections when processing long strings.
  • Regression Testing: Added comprehensive regression tests in paths.test.ts and atCommandProcessor.test.ts to ensure long tokens do not crash the CLI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a crash (issue #26368) caused by unhandled ENAMETOOLONG errors when processing long strings containing '@' symbols. The robustRealpath function in packages/core now explicitly catches ENAMETOOLONG alongside other expected filesystem errors. Regression tests have been added to both the CLI and core packages to ensure that long pasted strings are handled correctly without triggering unhandled rejections. I have no feedback to provide.

@gemini-cli

gemini-cli Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Hi there! Thank you for your interest in contributing to Gemini CLI.

To ensure we maintain high code quality and focus on our prioritized roadmap, we only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'.

This PR will be closed in 7 days if it remains without that designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@gemini-cli

gemini-cli Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding.

@gemini-cli gemini-cli Bot closed this May 18, 2026
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p2 Important but can be addressed in a future release. size/m A medium sized PR status/pr-nudge-sent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] CLI crashes with ENAMETOOLONG when pasting long strings into prompt

2 participants