Skip to content

fix(cli): add F10 fallback for approval mode cycling - #26088

Closed
Gitanaskhan26 wants to merge 10 commits into
google-gemini:mainfrom
Gitanaskhan26:fix/f10-approval-mode
Closed

fix(cli): add F10 fallback for approval mode cycling#26088
Gitanaskhan26 wants to merge 10 commits into
google-gemini:mainfrom
Gitanaskhan26:fix/f10-approval-mode

Conversation

@Gitanaskhan26

@Gitanaskhan26 Gitanaskhan26 commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Add F10 as a fallback keybinding for cycling the approval mode to improve terminal compatibility for Windows/WezTerm users.

Details

F10 serves as a reliable fallback where Shift+Tab sequences are incorrectly parsed by some Windows/WezTerm setups.

Related Issues

Fixes #22738

How to Validate

Run the gemini-cli and press F10 in a prompt mode to verify it successfully cycles the approval mode.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
    • Windows
    • Linux

@Gitanaskhan26
Gitanaskhan26 requested a review from a team as a code owner April 28, 2026 03:33
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience for CLI users, particularly those on Windows and using WezTerm, by introducing an additional keybinding for cycling the approval mode. This ensures that the functionality remains accessible and consistent across different terminal environments, resolving compatibility issues with existing key sequences.

Highlights

  • Keybinding Addition: Added F10 as an alternative keybinding for the CYCLE_APPROVAL_MODE command.
  • Terminal Compatibility: This change addresses issues where Shift+Tab sequences are incorrectly parsed in certain Windows/WezTerm terminal setups, providing a more reliable option.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces F10 as an alternative key binding for CYCLE_APPROVAL_MODE to address Shift+Tab compatibility issues in certain terminal environments. The reviewer recommends extending this fallback to other essential navigation commands that currently rely solely on Shift+Tab to prevent users from getting stuck in focus traps.

Comment thread packages/cli/src/ui/key/keyBindings.ts
@gemini-cli gemini-cli Bot added area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Apr 28, 2026
@gemini-cli gemini-cli Bot added priority/p3 Backlog - a good idea but not currently a priority. area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt labels May 13, 2026
Comment thread packages/cli/src/ui/key/keyBindings.ts
@Gitanaskhan26
Gitanaskhan26 force-pushed the fix/f10-approval-mode branch from 59dc43c to e306c13 Compare May 28, 2026 05:49
@Gitanaskhan26
Gitanaskhan26 requested a review from a team as a code owner May 28, 2026 05:49
@sehoon38 sehoon38 removed the area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt label May 29, 2026
@gemini-cli gemini-cli Bot added the area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt label May 29, 2026
@sehoon38

Copy link
Copy Markdown
Contributor

closing this as the related issue has been closed. thanks!

@sehoon38 sehoon38 closed this May 29, 2026
@sripasg sripasg added the size/m A medium sized PR label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p3 Backlog - a good idea but not currently a priority. size/m A medium sized PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows/WezTerm] Shift+Tab and fallback F10 fail to cycle approval mode (Keystroke logs included)

5 participants