fix(cli): add F10 fallback for approval mode cycling - #26088
fix(cli): add F10 fallback for approval mode cycling#26088Gitanaskhan26 wants to merge 10 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience for CLI users, particularly those on Windows and using WezTerm, by introducing an additional keybinding for cycling the approval mode. This ensures that the functionality remains accessible and consistent across different terminal environments, resolving compatibility issues with existing key sequences. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces F10 as an alternative key binding for CYCLE_APPROVAL_MODE to address Shift+Tab compatibility issues in certain terminal environments. The reviewer recommends extending this fallback to other essential navigation commands that currently rely solely on Shift+Tab to prevent users from getting stuck in focus traps.
59dc43c to
e306c13
Compare
|
closing this as the related issue has been closed. thanks! |
Summary
Add F10 as a fallback keybinding for cycling the approval mode to improve terminal compatibility for Windows/WezTerm users.
Details
F10 serves as a reliable fallback where
Shift+Tabsequences are incorrectly parsed by some Windows/WezTerm setups.Related Issues
Fixes #22738
How to Validate
Run the gemini-cli and press
F10in a prompt mode to verify it successfully cycles the approval mode.Pre-Merge Checklist