Repository navigation
fix(cli): don't crash when an @-mention captures a non-path blob #25980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scidomino
merged 5 commits into
google-gemini:main
from
ifitisit:fix/22029-paste-enametoolong
May 13, 2026
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
01bdd32
fix(cli): don't crash when an @-mention captures a non-path blob
ifitisit 6babe81
Merge branch 'main' into fix/22029-paste-enametoolong
ifitisit 0a3d4c3
Merge branch 'main' into fix/22029-paste-enametoolong
ifitisit d4f8625
Merge branch 'main' into fix/22029-paste-enametoolong
ifitisit 3c21e10
fix(cli): trim verbose comment per review
ifitisit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -188,9 +188,20 @@ export async function checkPermissions( | |
| const pathName = part.content.substring(1); | ||
| if (!pathName) continue; | ||
|
|
||
| const resolvedPathName = resolveToRealPath( | ||
| path.resolve(config.getTargetDir(), pathName), | ||
| ); | ||
| let resolvedPathName: string; | ||
| try { | ||
| resolvedPathName = resolveToRealPath( | ||
| path.resolve(config.getTargetDir(), pathName), | ||
| ); | ||
| } catch { | ||
| // The @-command regex is greedy and can capture pasted content (e.g. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this giant comment
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in 3c21e10 — trimmed to the suggested one-liner. Thanks! |
||
| // a JSON blob) that is not actually a path. Resolving such content | ||
| // through fs.realpathSync throws ENAMETOOLONG / EINVAL, which would | ||
| // otherwise propagate as an unhandled rejection and crash the CLI. | ||
| // Skip the entry — downstream rendering will surface a clearer error | ||
| // if the user really meant to reference a file. | ||
| continue; | ||
| } | ||
|
|
||
| if (config.validatePathAccess(resolvedPathName, 'read')) { | ||
| if (await fileExists(resolvedPathName)) { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.