Skip to content

fix(cli-ui): add modifyOtherKeys fallback for Ctrl+Backspace word delete #25943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TinyblackQvQ wants to merge 8 commits into from
Closed

fix(cli-ui): add modifyOtherKeys fallback for Ctrl+Backspace word delete #25943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9e1c5a2
fix(cli-ui): add modifyOtherKeys fallback for Ctrl+Backspace word del…
TinyblackQvQ Apr 24, 2026
b7e4704
Merge branch 'main' into fix/ctrl-backspace-modifyotherkeys-fallback
TinyblackQvQ Apr 24, 2026
cf77c91
Merge branch 'main' of https://github.com/google-gemini/gemini-cli in…
TinyblackQvQ May 3, 2026
d78f8f8
Add ModifyOtherKeys ctrl+backspace fallback test case.
TinyblackQvQ May 4, 2026
b1114d2
Merge branch 'fix/ctrl-backspace-modifyotherkeys-fallback' of https:/…
TinyblackQvQ May 4, 2026
8735718
Merge branch 'google-gemini:main' into fix/ctrl-backspace-modifyother…
TinyblackQvQ May 4, 2026
5108805
Merge branch 'fix/ctrl-backspace-modifyotherkeys-fallback' of https:/…
TinyblackQvQ May 4, 2026
683fb76
Merge branch 'main' into fix/ctrl-backspace-modifyotherkeys-fallback
spencer426 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/cli/src/ui/contexts/KeypressContext.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,17 @@ describe('KeypressContext', () => {
sequence: '\x1b[32;5u',
},
},
// Raw single-byte backspace sequences (no keyboard protocol)
{
name: 'Backspace (raw \\b = 0x08)',
inputSequence: '\b',
expected: { name: 'backspace', alt: false, ctrl: false, cmd: false },
},
{
name: 'Backspace (raw \\x7f = 0x7F)',
inputSequence: '\x7f',
expected: { name: 'backspace', alt: false, ctrl: false, cmd: false },
},
])(
'should recognize $name in kitty protocol',
async ({ inputSequence, expected }) => {
Expand Down Expand Up @@ -695,6 +706,11 @@ describe('KeypressContext', () => {
sequence: `\x1b[27;6;9~`,
expected: { name: 'tab', shift: true, ctrl: true },
},
// ModifyOtherKeys: Ctrl+Backspace (code 8 = backspace)
{
sequence: `\x1b[27;5;8~`,
expected: { name: 'backspace', ctrl: true },
},
// Unicode CJK (Kitty/modifyOtherKeys scalar values)
{
sequence: '\x1b[44032u',
Expand Down
10 changes: 8 additions & 2 deletions packages/cli/src/ui/contexts/KeypressContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ const KITTY_CODE_MAP: Record<number, { name: string; sequence?: string }> = {
3: { name: 'delete' },
5: { name: 'pageup' },
6: { name: 'pagedown' },
8: { name: 'backspace' },

@spencer426 spencer426 Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement (Minor):
Please add a test case for this new modifyOtherKeys fallback sequence (\x1b[27;5;8~) in packages/cli/src/ui/contexts/KeypressContext.test.tsx. There is an existing block called "Parameterized functional keys" where this would fit perfectly.

9: { name: 'tab' },
13: { name: 'enter' },
14: { name: 'up' },
Expand Down Expand Up @@ -652,8 +653,13 @@ function* emitKeys(
// tab
name = 'tab';
alt = escaped;
} else if (ch === '\b' || ch === '\x7f') {
// backspace or ctrl+h
} else if (ch === '\b') {
// backspace (0x08 - some terminals send this for ctrl+h/ctrl+backspace)
// Note: no ctrl=true heuristic is applied since raw \b is ambiguous
name = 'backspace';
alt = escaped;
} else if (ch === '\x7f') {
// backspace (0x7F - DEL, used as backspace on most modern terminals)
name = 'backspace';
alt = escaped;
} else if (ch === ESC) {
Expand Down