Skip to content

fix(core): prevent secondary crash in ModelRouterService finally block #25333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gundermanc merged 1 commit into from
Apr 13, 2026
Merged

fix(core): prevent secondary crash in ModelRouterService finally block #25333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/core/src/routing/modelRouterService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class ModelRouterService {
*/
async route(context: RoutingContext): Promise<RoutingDecision> {
const startTime = Date.now();
let decision: RoutingDecision;
let decision: RoutingDecision | undefined;

@gemini-code-assist gemini-code-assist Bot Apr 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Changing the type of decision to RoutingDecision | undefined will cause a TypeScript compilation error at the return statement (line 133), as the function's return type is Promise<RoutingDecision>. Instead of using a non-null assertion (!), you should handle the undefined case explicitly (e.g., by providing a default with ?? or throwing an error) to satisfy the compiler. This ensures you are coding against the interface contract rather than relying on implementation details that might change. Note that line 133 is outside the current diff hunks, so you will need to apply this fix manually.

References
  1. When a property or variable is optional in its type definition, callers must handle the undefined case explicitly (e.g., by providing a default) rather than relying on implementation details to guarantee a value.


const [enableNumericalRouting, thresholdValue] = await Promise.all([
this.config.getNumericalRoutingEnabled(),
Expand Down Expand Up @@ -117,10 +117,10 @@ export class ModelRouterService {
);
} finally {
const event = new ModelRoutingEvent(
decision!.model,
decision!.metadata.source,
decision!.metadata.latencyMs,
decision!.metadata.reasoning,
decision?.model || 'unknown',
decision?.metadata?.source || 'unknown',
decision?.metadata?.latencyMs || 0,
decision?.metadata?.reasoning,
failed,
error_message,
this.config.getApprovalMode(),
Expand Down
Loading