Repository navigation
Fix/web fetch ctrl c abort #24320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scidomino
merged 9 commits into
google-gemini:main
from
ProthamD:fix/web-fetch-ctrl-c-abort
May 15, 2026
Merged
Fix/web fetch ctrl c abort #24320
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2603f42
fix: prevent Ctrl+C retries on web_fetch by distinguishing user abort…
ProthamD 3f91404
Merge branch 'main' into fix/web-fetch-ctrl-c-abort
ProthamD 4250a36
chore: save implementation plan for web-fetch abort fix
ProthamD 1817e36
Merge branch 'fix/web-fetch-ctrl-c-abort' of https://github.com/Proth…
ProthamD d412410
Update packages/core/src/utils/fetch.ts
ProthamD 504c1ca
fix(core): address review comments on fetch abort handling
ProthamD b12c554
Merge branch 'main' into fix/web-fetch-ctrl-c-abort
ProthamD 23a018e
fix(core): address PR review comments for web fetch utils
ProthamD 17a977e
Merge branch 'main' into fix/web-fetch-ctrl-c-abort
ProthamD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will time out or hang indefinitely. In
fetch.test.ts, the mock implementation ofglobal.fetchonly listens for theabortevent. However, the test callscontroller.abort()before callingfetchWithTimeout. This meansinit.signalis already aborted by the timefetchis called, so theabortevent never fires, leaving the mocked promise hanging forever. The mock needs to be updated to checkinit?.signal?.abortedsynchronously.