Skip to content

fix(a2a-server): add missing return after 501 in /tasks/metadata endpoint #24293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garagon wants to merge 3 commits into from
+1 −0
Closed

fix(a2a-server): add missing return after 501 in /tasks/metadata endpoint #24293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9dca358
fix(a2a-server): add missing return after 501 in /tasks/metadata endp…
garagon Mar 31, 2026
b295894
Merge branch 'main' into fix/a2a-tasks-metadata-missing-return
garagon Mar 31, 2026
799ab7b
Merge branch 'main' into fix/a2a-tasks-metadata-missing-return
spencer426 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/a2a-server/src/http/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ export async function createApp() {
error:
'Listing all task metadata is only supported when using InMemoryTaskStore.',
});
return;

@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The /tasks/metadata endpoint lacks any authentication or authorization checks. While this PR correctly adds a return statement to prevent a server crash (DoS) when using a non-in-memory task store, the endpoint remains publicly accessible. Any unauthenticated user can retrieve metadata for all tasks currently in memory, which may include sensitive information such as workspace paths and agent settings for all users. It is recommended to apply authentication middleware to this route and ensure that users can only access metadata for tasks they own.

@gemini-code-assist gemini-code-assist Bot Mar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The /tasks/metadata endpoint lacks proper authorization checks. It returns metadata for all tasks currently in the InMemoryTaskStore, which includes sensitive information such as workspacePath and other agent settings. An authenticated user can access this information for all tasks, not just their own, leading to unauthorized information disclosure.

Remediation: Implement an authorization check to ensure that the user requesting the metadata is authorized to view it. Typically, this involves filtering the tasks to only include those owned by the current user or requiring administrative privileges to list all tasks.

}
try {
const wrappers = agentExecutor.getAllTasks();
Expand Down
Loading