Skip to content

fix(core): handle line endings in ignore file parsing #23895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cynthialong0-0 merged 2 commits into from
Apr 22, 2026
Merged

fix(core): handle line endings in ignore file parsing #23895

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cad88
fix(core): handle line endings in ignore file parsing
xoma-zver Mar 26, 2026
dc87c7f
Merge branch 'main' into fix/ignore-parsers-crlf
cynthialong0-0 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/utils/gitIgnoreParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export class GitIgnoreParser implements GitIgnoreFilter {
.split(path.sep)
.join(path.posix.sep);

const rawPatterns = content.split('\n');
const rawPatterns = content.split(/\r\n|\n|\r/);
return ignore().add(this.processPatterns(rawPatterns, relativeBaseDir));
}

Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/utils/ignoreFileParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class IgnoreFileParser implements IgnoreFileFilter {
debugLogger.debug(`Loading ignore patterns from: ${patternsFilePath}`);

return (content ?? '')
.split('\n')
.split(/\r\n|\n|\r/)
.map((p) => p.trim())
.filter((p) => p !== '' && !p.startsWith('#'));
}
Expand Down