Skip to content

fix: use synchronous stderr write before exit to prevent silent failures #23347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimjune01 wants to merge 4 commits into from
Closed

fix: use synchronous stderr write before exit to prevent silent failures #23347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4633d41
fix: use synchronous stderr write before exit to prevent silent failu…
kimjune01 Mar 21, 2026
ddc7041
fix: remove redundant async writeToStderr before exit
kimjune01 Mar 24, 2026
44633b7
test: update relaunch tests to assert on writeFileSync instead of wri…
kimjune01 Mar 30, 2026
3ac1a59
Merge branch 'main' into fix/16363-seatbelt-silent-fail
cocosheng-g Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions packages/cli/src/utils/relaunch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,18 @@ import {
import { EventEmitter } from 'node:events';
import { RELAUNCH_EXIT_CODE } from './processUtils.js';
import { spawn, type ChildProcess } from 'node:child_process';
import { writeFileSync } from 'node:fs';

const mocks = vi.hoisted(() => ({
writeToStderr: vi.fn(),
}));

vi.mock('@google/gemini-cli-core', async (importOriginal) => {
const actual =
await importOriginal<typeof import('@google/gemini-cli-core')>();
vi.mock('node:fs', async (importOriginal) => {
const actual = await importOriginal<typeof import('node:fs')>();
return {
...actual,
writeToStderr: mocks.writeToStderr,
writeFileSync: vi.fn(),
};
});

const mockedWriteFileSync = vi.mocked(writeFileSync);

vi.mock('node:child_process', async (importOriginal) => {
const actual = await importOriginal<typeof import('node:child_process')>();
return {
Expand All @@ -55,7 +53,7 @@ describe('relaunchOnExitCode', () => {
.spyOn(process.stdin, 'resume')
.mockImplementation(() => process.stdin);
vi.clearAllMocks();
mocks.writeToStderr.mockClear();
mockedWriteFileSync.mockClear();
});

afterEach(() => {
Expand Down Expand Up @@ -100,7 +98,8 @@ describe('relaunchOnExitCode', () => {
);

expect(runner).toHaveBeenCalledTimes(1);
expect(mocks.writeToStderr).toHaveBeenCalledWith(
expect(mockedWriteFileSync).toHaveBeenCalledWith(
2,
expect.stringContaining(
'Fatal error: Failed to relaunch the CLI process.',
),
Expand All @@ -123,7 +122,7 @@ describe('relaunchAppInChildProcess', () => {

beforeEach(() => {
vi.clearAllMocks();
mocks.writeToStderr.mockClear();
mockedWriteFileSync.mockClear();

process.env = { ...originalEnv };
delete process.env['GEMINI_CLI_NO_RELAUNCH'];
Expand Down
14 changes: 7 additions & 7 deletions packages/cli/src/utils/relaunch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@
* SPDX-License-Identifier: Apache-2.0
*/

import { writeFileSync } from 'node:fs';
import { spawn } from 'node:child_process';
import { RELAUNCH_EXIT_CODE } from './processUtils.js';
import {
writeToStderr,
type AdminControlsSettings,
} from '@google/gemini-cli-core';
import { type AdminControlsSettings } from '@google/gemini-cli-core';

@gemini-code-assist gemini-code-assist Bot Apr 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR description states that writeToStderr() is kept for compatibility, but it has been removed from the imports. Please restore the import.

Suggested change
import { type AdminControlsSettings } from '@google/gemini-cli-core';
import { writeToStderr, type AdminControlsSettings } from '@google/gemini-cli-core';


export async function relaunchOnExitCode(runner: () => Promise<number>) {
while (true) {
Expand All @@ -23,9 +21,11 @@ export async function relaunchOnExitCode(runner: () => Promise<number>) {
process.stdin.resume();
const errorMessage =
error instanceof Error ? (error.stack ?? error.message) : String(error);
writeToStderr(
`Fatal error: Failed to relaunch the CLI process.\n${errorMessage}\n`,
);
const message = `Fatal error: Failed to relaunch the CLI process.\n${errorMessage}\n`;
// Use synchronous write to fd 2 (stderr) to guarantee the message is
// visible before process.exit() terminates. The buffered writeToStderr()
// can lose output on macOS when stderr is piped.
writeFileSync(2, message);
process.exit(1);
}
}
Expand Down
Loading