Skip to content

fix(core): throttle shell text output UI updates #22843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbardy wants to merge 1 commit into from
Closed

fix(core): throttle shell text output UI updates #22843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/core/src/tools/shell.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,24 @@ export class ShellToolInvocation extends BaseToolInvocation<
switch (event.type) {
case 'data':
if (isBinaryStream) break;
cumulativeOutput = event.chunk;
shouldUpdate = true;
// PTY mode emits AnsiOutput (full terminal snapshot) —
// overwrite. Pipe mode emits partial strings — accumulate
// so intermediate chunks aren't lost between throttled
// UI updates.
if (typeof event.chunk === 'string') {
cumulativeOutput =
typeof cumulativeOutput === 'string'
? cumulativeOutput + event.chunk
: event.chunk;
} else {
cumulativeOutput = event.chunk;
}
// Throttle UI updates to avoid excessive re-renders when
// commands produce high-volume output (e.g. thousands of
// warning lines).
if (Date.now() - lastUpdateTime > OUTPUT_UPDATE_INTERVAL_MS) {
shouldUpdate = true;
}
break;
case 'binary_detected':
isBinaryStream = true;
Expand Down