fix: enable Gemini 3.1 Pro for UserTierId.STANDARD subscribers - #20206
fix: enable Gemini 3.1 Pro for UserTierId.STANDARD subscribers#20206sun-9545sunoj wants to merge 5 commits into
Conversation
Summary of ChangesHello @sun-9545sunoj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where Google AI Pro subscribers (Standard Tier) were unable to access Gemini 3.1 Pro. The changes enhance the feature flag logic to correctly identify and enable Gemini 3.1 Pro for users with a Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly enables Gemini 3.1 Pro for STANDARD tier users by updating the getGemini31LaunchedSync logic. The accompanying tests are a great addition and cover the new logic paths. However, I've identified a minor issue in the test implementation where a spy is used ineffectively, making the tests brittle. I've provided a suggestion to improve the test's robustness.
resolving the changes sugested
|
what's keeping this pending? This is a big blocker for paid users of gemini. |
|
Neve mind. Duplicate of Fix #19676 |
|
Hi there! Thank you for your interest in contributing to Gemini CLI. To ensure we maintain high code quality and focus on our prioritized roadmap, we have updated our contribution policy (see Discussion #17383). We only guarantee review and consideration of pull requests for issues that are explicitly labeled as 'help wanted'. All other community pull requests are subject to closure after 14 days if they do not align with our current focus areas. For this reason, we strongly recommend that contributors only submit pull requests against issues explicitly labeled as 'help-wanted'. This pull request is being closed as it has been open for 14 days without a 'help wanted' designation. We encourage you to find and contribute to existing 'help wanted' issues in our backlog! Thank you for your understanding and for being part of our community! |
Description
This PR addresses the issue where Gemini 3.1 Pro was unavailable or not selectable for Google AI Pro subscribers (Standard Tier).
I have updated the
getGemini31LaunchedSync()logic to verify theuserTierfrom the Code Assist server. If the tier isUserTierId.STANDARD, the model is now correctly enabled.Changes
config.tsto include a check forUserTierId.STANDARD.UserTierIdto runtime imports inconfig.ts.describeblock inconfig.test.tscovering all activation paths (AuthType, UserTier, and Experiment Flags).vi.mocked()incorrectly on non-mocked methods.Verification
UserTierId.STANDARDcorrectly returnstruefor Gemini 3.1 access.Fixes #20128