fix spacing - #19494
Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jacob314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a user interface spacing issue within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly addresses a spacing issue in the UI where split tool groups (e.g., when part of a tool group is in history and part is pending) were rendered with an unnecessary gap. By conditionally setting marginBottom to 0 when borderBottom is explicitly disabled, the components now visually merge as intended. A regression test with a snapshot has been added to verify this behavior. The changes are minimal, focused, and follow the repository's coding standards and existing patterns. No high or critical issues were identified during the review.
|
Size Change: +35 B (0%) Total Size: 24.5 MB ℹ️ View Unchanged
|
gemini-cli
Bot
added
the
priority/p1
The unconditionally applied `marginBottom={1}` introduced in PR #17198 caused a visual gap
when a tool group is partially rendered between the static and pending areas
(i.e. `borderBottomOverride === false`).
By conditioning `marginBottom` on `borderBottomOverride !== false`, intermediate chunks
seamlessly connect with their bottom border chunks, while completed tool groups
still get the appropriate padding margin.
Fixes regression introduced in e7f97df.
…ontent This test simulates a tool group split between history (rendered via Static) and pending items. It verifies that they are rendered without a visual gap, which ensures the `marginBottom` fix in `ToolGroupMessage` is working as expected in the actual application context.
87ec081 to
fc158ec
Compare
3 participants
Summary
Fixes #19493 and adds a regression test so it is easy to see from the snapshots if this is regressed again.