Remove unnecessary eslint config file

[scidomino]

Summary

Remove unnecessary eslint config file

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on project cleanup by removing a redundant ESLint configuration file. The removal simplifies the project structure and eliminates an unneeded configuration, contributing to a leaner and more maintainable codebase without impacting the overall linting setup, which is presumably handled at a higher level.

Highlights

• Configuration Cleanup: The eslint.config.mjs file within the packages/vscode-ide-companion directory has been removed, as it was deemed unnecessary.

Changelog

• packages/vscode-ide-companion/eslint.config.mjs
  • Removed the entire ESLint configuration file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the ESLint configuration file for the vscode-ide-companion package. While consolidating ESLint configurations is a good goal, this change is problematic. The root eslint.config.js applies React-specific linting rules globally, but the vscode-ide-companion package does not use React. Applying these rules is incorrect and can lead to false linting errors. Therefore, this package-specific configuration is still necessary until the root configuration is adjusted to apply React rules only to the relevant packages.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/vscode-ide-companion/eslint.config.mjs (1-50)

This file should not be removed. The root eslint.config.js applies React-specific linting rules (from eslint-plugin-react and eslint-plugin-react-hooks) to all packages. However, vscode-ide-companion is not a React-based project, so applying these rules is incorrect and can cause misleading lint errors.

To fix this, the root ESLint configuration should be modified to scope the React-specific rules only to the packages that actually use React. Until that is done, this package-specific configuration is required to ensure correct linting for vscode-ide-companion.

[github-actions]

Size Change: -2 B (0%)

Total Size: 24.4 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.4 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}