fix(acp): Wait for mcp initialization in acp (#18893)

[Mervap]

Summary

Fixes mcp initialization in ACP mode

Details

ACP mode assumed to be Config.interactive, which caused MCP initialization to run in the background. As a result, when the first GeminiAgent.prompt request is received, MCP may not be connected yet (or it may be!), and the agent can produce inconsistent responses

Related Issues

Fixes ##18893

How to Validate

Add a slow MCP server, send prompt request immediately after newSession request

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @Mervap, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a timing issue where the Micro-Controller Platform (MCP) might not be fully ready when an agent attempts to interact with it, particularly in ACP mode. By adjusting the initialization logic, it guarantees that MCP is properly set up, preventing potential inconsistencies in agent responses and improving system stability.

Highlights

• MCP Initialization Fix: Ensured that the Micro-Controller Platform (MCP) is fully initialized before an agent attempts to use it, specifically addressing issues in ACP mode where MCP initialization might run asynchronously, leading to inconsistent responses.

Changelog

• packages/core/src/config/config.ts
  • Modified the condition for awaiting mcpInitialization to include experimentalZedIntegration alongside !this.interactive.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a race condition where MCP initialization could run in the background in ACP mode, potentially causing inconsistent behavior. The fix correctly modifies the logic to await the MCP initialization promise when experimentalZedIntegration is true, ensuring that MCP servers are fully connected before proceeding. This change is a direct and effective solution to the described problem.