Skip to content

test(core): remove hardcoded model from TestRig #18710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NTaylorMullen merged 1 commit into from
Feb 10, 2026
Merged

test(core): remove hardcoded model from TestRig #18710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions evals/shell-efficiency.eval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('Shell Efficiency', () => {
return typeof args === 'string' ? args : (args as any)['command'];
};

evalTest('ALWAYS_PASSES', {
evalTest('USUALLY_PASSES', {
name: 'should use --silent/--quiet flags when installing packages',
prompt: 'Install the "lodash" package using npm.',
assert: async (rig) => {
Expand Down Expand Up @@ -49,7 +49,7 @@ describe('Shell Efficiency', () => {
},
});

evalTest('ALWAYS_PASSES', {
evalTest('USUALLY_PASSES', {
name: 'should use --no-pager with git commands',
prompt: 'Show the git log.',
assert: async (rig) => {
Expand All @@ -72,7 +72,7 @@ describe('Shell Efficiency', () => {
},
});

evalTest('ALWAYS_PASSES', {
evalTest('USUALLY_PASSES', {
name: 'should NOT use efficiency flags when enableShellOutputEfficiency is disabled',
params: {
settings: {
Expand Down
3 changes: 3 additions & 0 deletions integration-tests/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@ export default defineConfig({
maxThreads: 16,
},
},
env: {
GEMINI_TEST_TYPE: 'integration',
},
},
});
10 changes: 7 additions & 3 deletions packages/test-utils/src/test-rig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,13 @@ export class TestRig {
ui: {
useAlternateBuffer: true,
},
model: {
name: DEFAULT_GEMINI_MODEL,
},
...(env['GEMINI_TEST_TYPE'] === 'integration'
? {
model: {
name: DEFAULT_GEMINI_MODEL,
},
}
: {}),
sandbox:
env['GEMINI_SANDBOX'] !== 'false' ? env['GEMINI_SANDBOX'] : false,
// Don't show the IDE connection dialog when running from VsCode
Expand Down
Loading