Skip to content

feat(cli): update approval mode labels and shortcuts per latest UX spec #18698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerop merged 1 commit into from
Feb 10, 2026
+14 −14
Merged

feat(cli): update approval mode labels and shortcuts per latest UX spec #18698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ describe('ApprovalModeIndicator', () => {
<ApprovalModeIndicator approvalMode={ApprovalMode.AUTO_EDIT} />,
);
const output = lastFrame();
expect(output).toContain('auto-edit');
expect(output).toContain('shift + tab to enter default mode');
expect(output).toContain('auto-accept edits');
expect(output).toContain('shift+tab to manual');
});

it('renders correctly for AUTO_EDIT mode with plan enabled', () => {
Expand All @@ -27,8 +27,8 @@ describe('ApprovalModeIndicator', () => {
/>,
);
const output = lastFrame();
expect(output).toContain('auto-edit');
expect(output).toContain('shift + tab to enter default mode');
expect(output).toContain('auto-accept edits');
expect(output).toContain('shift+tab to manual');
});

it('renders correctly for PLAN mode', () => {
Expand All @@ -37,7 +37,7 @@ describe('ApprovalModeIndicator', () => {
);
const output = lastFrame();
expect(output).toContain('plan');
expect(output).toContain('shift + tab to enter auto-edit mode');
expect(output).toContain('shift+tab to accept edits');
});

it('renders correctly for YOLO mode', () => {
Expand All @@ -46,15 +46,15 @@ describe('ApprovalModeIndicator', () => {
);
const output = lastFrame();
expect(output).toContain('YOLO');
expect(output).toContain('shift + tab to enter auto-edit mode');
expect(output).toContain('ctrl+y');
});

it('renders correctly for DEFAULT mode', () => {
const { lastFrame } = render(
<ApprovalModeIndicator approvalMode={ApprovalMode.DEFAULT} />,
);
const output = lastFrame();
expect(output).toContain('shift + tab to enter auto-edit mode');
expect(output).toContain('shift+tab to accept edits');
});

it('renders correctly for DEFAULT mode with plan enabled', () => {
Expand All @@ -65,6 +65,6 @@ describe('ApprovalModeIndicator', () => {
/>,
);
const output = lastFrame();
expect(output).toContain('shift + tab to enter plan mode');
expect(output).toContain('shift+tab to plan');
});
});
12 changes: 6 additions & 6 deletions packages/cli/src/ui/components/ApprovalModeIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,26 @@ export const ApprovalModeIndicator: React.FC<ApprovalModeIndicatorProps> = ({
switch (approvalMode) {
case ApprovalMode.AUTO_EDIT:
textColor = theme.status.warning;
textContent = 'auto-edit';
subText = 'shift + tab to enter default mode';
textContent = 'auto-accept edits';
subText = 'shift+tab to manual';
break;
case ApprovalMode.PLAN:
textColor = theme.status.success;
textContent = 'plan';
subText = 'shift + tab to enter auto-edit mode';
subText = 'shift+tab to accept edits';
break;
case ApprovalMode.YOLO:
textColor = theme.status.error;
textContent = 'YOLO';
subText = 'shift + tab to enter auto-edit mode';
subText = 'ctrl+y';
break;
case ApprovalMode.DEFAULT:
default:
textColor = theme.text.accent;
textContent = '';
subText = isPlanEnabled
? 'shift + tab to enter plan mode'
: 'shift + tab to enter auto-edit mode';
? 'shift+tab to plan'
: 'shift+tab to accept edits';
break;
}

Expand Down
Loading