refactor(cli): simplify UI and remove legacy inline tool confirmation logic

[abhipatel12]

Summary

This PR simplifies the CLI's UI components by removing legacy inline tool confirmation logic. Since the event-driven scheduler now handles all tool confirmations in a global queue at the bottom of the terminal, the inline interactive elements and associated branching logic in the conversation history are no longer needed.

Details

• ToolGroupMessage.tsx: Removed the isEventDriven flag. It now always hides Pending and Confirming tools from the history log.
• ToolGroupMessage.tsx: Removed the inline ToolConfirmationMessage rendering and associated "dimming" logic for tools awaiting approval.
• MainContent.tsx & AlternateBufferQuittingDisplay.tsx: Simplified the logic to always show the Global Confirmation Queue when a tool is awaiting approval, removing redundant configuration checks.
• Tests: Refactored ToolGroupMessage.test.tsx to assume the event-driven behavior as the default and deleted ToolConfirmationMessageOverflow.test.tsx as the inline overflow path is obsolete.

Related Issues

Part 2 of the legacy scheduler cleanup in the CLI package.

How to Validate

1. Run npm run test -w @google/gemini-cli to ensure all simplified UI tests pass.
2. Trigger a tool call requiring confirmation and verify that the confirmation prompt appears correctly in the Global Queue and NOT inline within the message history.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run

[gemini-code-assist]

Summary of Changes

Hello @abhipatel12, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the CLI's user interface by deprecating and removing outdated inline tool confirmation mechanisms. By fully embracing the event-driven scheduler, all tool confirmations are now consistently managed through a global queue, leading to a cleaner and more predictable user experience. The changes simplify the underlying codebase by removing conditional logic and legacy components that are no longer necessary.

Highlights

• UI Simplification: Removed legacy inline tool confirmation logic and UI components from the CLI, standardizing all tool confirmations to be handled by the global queue at the bottom of the terminal.
• Codebase Cleanup: Eliminated the isEventDriven flag and associated conditional logic across various UI components, as the event-driven scheduler is now the default and sole mechanism for tool confirmations.
• Test Refactoring: Updated ToolGroupMessage.test.tsx to reflect the new default behavior of hiding pending and confirming tools from the history log, and deleted the obsolete ToolConfirmationMessageOverflow.test.tsx.
• Scheduler Unification: The useToolScheduler hook now exclusively uses the useToolExecutionScheduler, removing the facade logic that previously switched between legacy and event-driven schedulers.

Changelog

• packages/cli/src/test-utils/mockConfig.ts
  • Removed isEventDrivenSchedulerEnabled from mock configuration, reflecting its deprecation.
• packages/cli/src/ui/components/AlternateBufferQuittingDisplay.tsx
  • Removed useConfig import and isEventDrivenSchedulerEnabled check.
  • Simplified showPromptedTool logic to directly depend on confirmingTool presence.
• packages/cli/src/ui/components/MainContent.tsx
  • Removed useConfig import and isEventDrivenSchedulerEnabled check.
  • Simplified showConfirmationQueue logic to directly depend on confirmingTool presence.
• packages/cli/src/ui/components/messages/ToolConfirmationMessageOverflow.test.tsx
  • Deleted obsolete test file for inline tool confirmation overflow.
• packages/cli/src/ui/components/messages/ToolGroupMessage.test.tsx
  • Removed createMockSettings import and enableEventDrivenScheduler from mock config.
  • Updated tests to assert that Confirming and Pending tools are now hidden by default in ToolGroupMessage.
  • Removed test cases related to legacy inline confirmation handling and conditional event-driven scheduler behavior.
• packages/cli/src/ui/components/messages/ToolGroupMessage.tsx
  • Removed ToolConfirmationMessage and useConfig imports.
  • Removed isFocused prop from component definition.
  • Removed isEventDriven flag and conditional logic; visibleToolCalls now always filters out Pending and Confirming tools.
  • Removed toolAwaitingApproval memoization and related emphasis logic, setting emphasis to 'medium' by default.
  • Removed inline rendering of ToolConfirmationMessage.
• packages/cli/src/ui/components/messages/snapshots/ToolGroupMessage.test.tsx.snap
  • Updated snapshots to reflect the new UI behavior where confirming and pending tools are hidden from the history log.
• packages/cli/src/ui/hooks/useGeminiStream.ts
  • Removed isEventDriven flag and conditional logic, assuming event-driven behavior for tool visibility.
• packages/cli/src/ui/hooks/useToolScheduler.ts
  • Removed imports for useReactToolScheduler and LegacyTrackedToolCall.
  • Removed the TrackedToolCall union type.
  • Modified useToolScheduler to directly call useToolExecutionScheduler, eliminating the conditional facade.
• packages/cli/src/ui/hooks/useToolSchedulerFacade.test.ts
  • Deleted obsolete test file for the useToolScheduler facade.

Activity

• The pull request author, abhipatel12, created this PR to simplify the CLI's UI by removing legacy inline tool confirmation logic.
• The author provided a detailed summary, specific changes, related issues, validation steps, and a pre-merge checklist in the PR description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -1.59 kB (-0.01%)

Total Size: 24.3 MB

Filename	Size	Change
./bundle/gemini.js	24.3 MB	-1.59 kB (-0.01%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request is a solid refactoring that simplifies the UI by removing the legacy inline tool confirmation logic and standardizing on the event-driven scheduler with a global confirmation queue. The changes are consistent across components, hooks, and tests, leading to a cleaner and more maintainable codebase. I've identified one area for improvement to fully complete the legacy code removal, which involves cleaning up a now-unused file and its associated type definitions.

[jacob314]

So much deleted code!

[jacob314]

Great cleanup! Removing the legacy inline confirmation logic significantly simplifies the UI state and aligns perfectly with the event-driven scheduler.

A few minor points for consistency and further cleanup:

1. Redundant Comments: In packages/cli/src/ui/components/messages/ToolGroupMessage.tsx, there are still comments referring to "If Event-Driven Scheduler is enabled" (lines 63-64, 110-111). Since this is now the standard behavior, these comments should be updated to reflect the current architecture without referencing the old flag.
2. Redundant Test Case: In packages/cli/src/ui/components/messages/ToolGroupMessage.test.tsx, the test case "renders when not focused" (lines 202-214) is now identical to "renders single successful tool call" because the isFocused prop was removed. This test can be deleted.
3. Snapshot Redundancy: In the same test file, the test "hides confirming tools (standard behavior)" uses expect(lastFrame()).toBe('') followed by toMatchSnapshot(). Since you're already asserting the frame is empty, the empty snapshot is redundant.
4. Ask User filtering: In ToolGroupMessage.tsx, the isAskUserInProgress helper is used to filter out AskUser tools. Since ToolGroupMessage now also filters out all Pending and Confirming tools generally, verify if there's any remaining case where isAskUserInProgress provides unique filtering (e.g., for Executing status). It looks correct, but worth a quick double-check.

Overall, the code quality is high and the logic is much cleaner.