Adding a new parameter for model, and updating the default to 2.5 Flash. - #18
Merged
Conversation
NTaylorMullen
approved these changes
Apr 18, 2025
rakyll
reviewed
Apr 18, 2025
| @@ -0,0 +1,50 @@ | |||
| import { CliArgs } from './args.js'; // Assuming CliArgs contains the needed fields | |||
Contributor
There was a problem hiding this comment.
We should merge config into a single module.
Introduce a loadConfig that parses args, loads from environment, etc.
We should also avoid global state. Just pass a config type.
keithballinger
pushed a commit
that referenced
this pull request
Jun 13, 2025
yaleh
pushed a commit
to yaleh/gemini-cli
that referenced
this pull request
Jun 29, 2025
joneba-google
added a commit
to JonE01/gemini-cli
that referenced
this pull request
Aug 19, 2026
…namic mimetypes Address PR code review feedback by implementing exact code suggestions for Comment google-gemini#17 and Comment google-gemini#18. ### Motivation Local trace creation in world-writable directories required symlink guards and restricted mode permissions (0o700) to prevent overwrite attacks. Evaluation artifact uploads needed dynamic MIME type guessing via mimetypes.guess_type for binary assets. ### Key Changes - Added mode=0o700 to os.makedirs and os.path.islink guard to prevent local symlink overwrite attacks in upload_agent_trajectory_log. - Added fallback sanitization (os.path.basename) for non-integer issue_number identifiers. - Added mimetypes.guess_type in upload_eval_run_artifacts to dynamically set content_type for uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.