Skip to content

fix(core): add error logging for IDE fetch failures #17981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adib234 merged 4 commits into from
Feb 19, 2026
Merged

fix(core): add error logging for IDE fetch failures #17981

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e562e59
fix(core): add error logging for IDE fetch failures
yuvrajangadsingh Jan 30, 2026
1148aa7
fix: pass full error object for stack trace logging
yuvrajangadsingh Jan 30, 2026
767c0bc
fix: handle Request object type when logging URL
yuvrajangadsingh Feb 6, 2026
f5df8ac
fix: simplify URL string construction for error logging
yuvrajangadsingh Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions packages/core/src/ide/ide-connection-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,19 @@ export async function createProxyAwareFetch(ideServerHost: string) {
};
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
const options = fetchOptions as unknown as import('undici').RequestInit;
const response = await fetchFn(url, options);
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion
return new Response(response.body as ReadableStream<unknown> | null, {
status: response.status,
statusText: response.statusText,
headers: [...response.headers.entries()],
});
try {
const response = await fetchFn(url, options);
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion

@Adib234 Adib234 Feb 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to not disable this lint rule?

@yuvrajangadsingh yuvrajangadsingh Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, that disable was already there before my changes — I just wrapped the existing code in a try/catch. the cast is needed because Node's RequestInit and undici's RequestInit don't play nice with each other, so going through unknown is the only option there.

return new Response(response.body as ReadableStream<unknown> | null, {
status: response.status,
statusText: response.statusText,
headers: [...response.headers.entries()],
});
} catch (error) {
const urlString = typeof url === 'string' ? url : url.href;
Comment thread
yuvrajangadsingh marked this conversation as resolved.
Comment thread
yuvrajangadsingh marked this conversation as resolved.
logger.error(`IDE fetch failed for ${urlString}`, error);
throw error;
}
};
}

Expand Down
Loading