Skip to content

Fix: Avoid tool confirmation timeout when no UI listeners are present #17955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skeshive merged 1 commit into from
Feb 19, 2026
Merged

Fix: Avoid tool confirmation timeout when no UI listeners are present #17955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions packages/core/src/confirmation-bus/message-bus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,21 @@ export class MessageBus extends EventEmitter {
});
break;
case PolicyDecision.ASK_USER:
// Pass through to UI for user confirmation
this.emitMessage(message);
// Pass through to UI for user confirmation if any listeners exist.
// If no listeners are registered (e.g., headless/ACP flows),
// immediately request user confirmation to avoid long timeouts.
if (
this.listenerCount(MessageBusType.TOOL_CONFIRMATION_REQUEST) > 0
) {
this.emitMessage(message);
} else {
this.emitMessage({
type: MessageBusType.TOOL_CONFIRMATION_RESPONSE,
correlationId: message.correlationId,
confirmed: false,
requiresUserConfirmation: true,
});
}
break;
default:
throw new Error(`Unknown policy decision: ${decision}`);
Expand Down
Loading