UI: standardize "focus" (fka "selection") color across themes

[keithguerin]

Summary

Standardize the selection color in the CLI across all themes and UI components using a new selection semantic token. This decouples selection highlighting from the status.success color.

Details

• Semantic Tokens: Added selection to the SemanticColors interface and mapped it to AccentGreen in all base themes (light, dark, ANSI).
• Theme Support: Updated the Theme constructor and createCustomTheme to support the new token, ensuring custom themes can also define their own selection color.
• UI Components:
  • Updated SuggestionsDisplay (autocomplete menu for / and @) to use the selection token.
  • Updated SettingsDialog to use the selection token for active items.
  • Updated SessionBrowser (session resume menu) to use the selection token.
  • Updated BaseSelectionList (and by extension RadioButtonSelect) to use the selection token.
• Built-in Themes: Updated DefaultDark and DefaultLight to explicitly pass their semantic color definitions.
• Tests: Updated Header.test.tsx and no-color.ts mocks to include the new property.

Related Issues

None.

How to Validate

1. Run npm run build to ensure the project compiles without errors.
2. Open various menus (/, /settings, /resume) and verify that the selection color is consistent and follows the theme's green accent (or custom selection color if defined).

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run build
    • typecheck

Fixes #18719

[gemini-code-assist]

Summary of Changes

Hello @keithguerin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the CLI's user interface by standardizing the selection color across all available themes. By consistently applying the AccentGreen token, the change aims to provide a more cohesive and predictable visual experience for users, enhancing usability and aesthetic uniformity throughout the application.

Highlights

• Standardized Selection Color: The selection color in the CLI has been standardized across all themes to use the AccentGreen semantic token, ensuring visual consistency.
• SemanticColors Interface Update: The SemanticColors interface now includes a selection property to support the new standardized color.
• Theme Configuration Updates: The createCustomTheme function and the Theme constructor have been updated to properly handle and apply the new selection semantic color.
• NoColorTheme and Test File Adjustments: The NoColorTheme and Header.test.tsx files were updated to include the selection property, ensuring comprehensive theme support and test coverage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively standardizes the selection color across themes by introducing a selection semantic token and mapping it to AccentGreen. The changes are consistently applied across the different theme definitions, the Theme class, and test mocks.

I've left one comment in packages/cli/src/ui/themes/theme.ts regarding a logical redundancy and a potential design improvement in the createCustomTheme function. Addressing this will improve code clarity and maintainability. Overall, this is a good enhancement for theme consistency.

[gemini-code-assist]

Tying the selection color to status.success for custom themes might be inflexible, as a user may want to configure them independently. A better long-term solution would be to add a selection property to the ui object in the CustomTheme interface for separate customization.

For the current implementation, there is a logical redundancy. The expression customTheme.status?.success ?? colors.AccentGreen is unnecessarily complex because colors.AccentGreen (defined on line 274) is already configured to use customTheme.status?.success as its primary source.

You can simplify this to make the code cleaner and avoid the redundant check.

Suggested change

	selection: customTheme.status?.success ?? colors.AccentGreen,
	selection: colors.AccentGreen,

[jacob314]

revert changes to all the package.json files. These are spurious

[jacob314]

Approved once *.json are reverted from the PR and plan.md is reverted.

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details, see the GitHub Documentation.

Thank you for your understanding and for being a part of our community!

[gemini-cli]

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

[keithguerin]

Merged into #20489 to consolidate color changes.