Skip to content

Improve request_options #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markmcd merged 13 commits into from
May 17, 2024
Merged

Improve request_options #297

markmcd merged 13 commits into from
May 17, 2024

Conversation

@MarkDaoust
Copy link
Collaborator

@MarkDaoust MarkDaoust commented Apr 22, 2024 •
edited
Loading

Fixes: #223

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Apr 22, 2024
@MarkDaoust MarkDaoust marked this pull request as draft April 23, 2024 17:29
@MarkDaoust
Add helper_types
511c6aa 
Change-Id: Idc3e813616413f4ce085c05b771c0127e4dfc886
@MarkDaoust
format
e0c781c 
Change-Id: I186e015de97ceece56ee5a97f6edef47ef223d18
@MarkDaoust
UpdateRequestOptions
c2aaad4 
Change-Id: I9f92466967fb1aa605d442cb143699da4308409b
@MarkDaoust
Add docs
424f922 
Change-Id: I209b2b2ad8d783001b1828cbcac84ca301c11bec
@MarkDaoust
work
fd78b30 
Change-Id: I00a2e2edb1e9bf3d4f51c0a868a34e044be3c6ff
@MarkDaoust
Merge branch 'main' into request_options
cb567df 
Change-Id: Ifdeea09c1c555f57640977ccc6c7b8e95fc148f6
@MarkDaoust
Fix Py3.9
25ea416 
Change-Id: I8cf0ccac90ba3c4548e7549fec7d0b9b58925e7e
@MarkDaoust
use RequestOptions in tests
78b7407 
Change-Id: I92b68bc86330ad874c3765f428a2e64ba220750f
@MarkDaoust
annotations
4d653f8 
Change-Id: Idbc428075729255d66d2ba8b3bcce0a1d6e8f048
@MarkDaoust MarkDaoust marked this pull request as ready for review April 27, 2024 00:29
@MarkDaoust MarkDaoust changed the title Working on request_options Improve request_options May 3, 2024
mayureshagashe2105
mayureshagashe2105 approved these changes May 3, 2024
View reviewed changes
markmcd
markmcd previously approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely not blocking, but it'd be nice if both the dict & DC params were tested explicitly, rather than as part of the feature tests (e.g. something like test_helpers.py with test_request_options_dict, test_request_options_dc)

MarkDaoust and others added 2 commits May 8, 2024 05:38
@MarkDaoust @markmcd
Update tests/test_discuss.py
11afaa3 
Co-authored-by: Mark McDonald <[email protected]>
@MarkDaoust
tests
418a38c 
Change-Id: Ife30e2cc47bd4c52d2dddafdd85a51df0e42e160
@MarkDaoust
Copy link
Collaborator Author

MarkDaoust commented May 8, 2024

but it'd be nice if both the dict & DC params were tested explicitly

Done.

@markmcd markmcd merged commit 30337c2 into google-gemini:main May 17, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 17, 2024
@mayureshagashe2105 mayureshagashe2105 mentioned this pull request May 24, 2024
Closed
@josealvarez97 josealvarez97 mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmcd markmcd markmcd approved these changes

@shilpakancharla shilpakancharla Awaiting requested review from shilpakancharla

+1 more reviewer

@mayureshagashe2105 mayureshagashe2105 mayureshagashe2105 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:python sdk Issue/PR related to Python SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

There should be a RequestOptions TypedDict to explain what attributes are allowed.

3 participants

@MarkDaoust @markmcd @mayureshagashe2105