Fix memory leak in radam optimizer #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace jax.lax.cond with jnp.where. This increases computational time, but fixes the memory leak. This solution was originally proposed by vroulet@.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vroulet
approved these changes
May 27, 2024
There was a problem hiding this comment.
Looks great, thank you very much @lukekulik.
Just to make sure: did you try and did it solve the memory leak issue?
|
Yes, it looks like it fixed it. The number of live buffers in the the repro example from #969 doesn't continue to grow anymore. |
|
Perfect thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #969
Replace jax.lax.cond with jnp.where in the radam optimizer update function. This increases computational time, but fixes the memory leak. This solution was originally proposed by vroulet@.