Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mathematical documentation to AdaMax #918

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

hmludwig
Copy link
Contributor

@hmludwig hmludwig commented Apr 9, 2024

I added mathematical documentation to AdaMax.
Results look like this:
Screenshot 2024-04-09 at 13 17 00

@hmludwig
Copy link
Contributor Author

hmludwig commented Apr 9, 2024

On the screenshot v_t appears twice, this isn't the case in the final commit. Just uploaded the wrong screenshot.

Copy link
Collaborator

@vroulet vroulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @hmludwig ! Just a small comment left and it's good to go.

optax/_src/alias.py Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit b259e5d into google-deepmind:main Apr 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants