fix the default learning rate in prodigy #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Konstantin! The changes look good to me. The tests are failing, seems to me for unrelated reasons .... i'm looking into it |
|
Thanks @konstmish! The prodigy test fails with this default learning rate. To fix this, it suffices to change the test for the algorithm to run for 100 000 iterations instead of 10 000 iterations. Could you take care of it in this PR? Thanks! |
|
There seems to be anyway something wrong with the CI. Everything is failing with an obscure |
|
seems its a problem with the most recent release of pytest. Downgrading it seemed to solve the issue: #743 |
|
should be fixed now in main (2e69e7f). Please update this branch and 🤞🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing the current version of Prodigy that has a typo: the learning was set to 0.1 instead of 1.0