Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial step of scale_by_optimistic_gradient. #1088

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix initial step of scale_by_optimistic_gradient. #1088

merged 1 commit into from
Oct 8, 2024

Conversation

carlosgmartin
Copy link
Contributor

Fixes #1082.

@carlosgmartin carlosgmartin mentioned this pull request Oct 3, 2024
Closed
fabianp
fabianp reviewed Oct 3, 2024
View reviewed changes
optax/_src/transform.py Outdated Show resolved Hide resolved
@carlosgmartin carlosgmartin force-pushed the fix_scale_by_optimistic_gradient branch from 21bc608 to af5badd Compare October 3, 2024 19:15
@fabianp
Copy link
Member

fabianp commented Oct 4, 2024

excellent, thanks!

@copybara-service copybara-service bot merged commit f9e7772 into google-deepmind:main Oct 8, 2024
7 of 8 checks passed
@carlosgmartin carlosgmartin deleted the fix_scale_by_optimistic_gradient branch October 8, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianp fabianp fabianp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible issue with the initial step of scale_by_optimistic_gradient
2 participants
@carlosgmartin @fabianp