-
Notifications
You must be signed in to change notification settings - Fork 183
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Start inject_hyperparams step count at 0.
This fixes issue #415. Previously, `inject_hyperparams` started with `step_count=1` in the first update when using schedules (it incremented before passing it to the schedule) whereas `scale_by_schedule` started with `step_count=0`. To make this consistent, this PR changes `inject_hyperparams` to also start at 0, i.e. increment the count only after passing it to the schedule. The PR comes with a test that breaks without the change. Furthermore, the step counts in the existing tests of `inject_hyperparams` had to be decremented by one in order for the tests to pass. PiperOrigin-RevId: 479553657
- Loading branch information
Showing
2 changed files
with
14 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters