Add survival and log-survival function to distrax.Distribution base class.
#148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
copybara-service
bot
force-pushed
the
test_443160366
branch
3 times, most recently
from
8a2fd38
to
10bd0db
Compare
… class. Note that by default we use a numerically not necessarily stable definition of the survival function in terms of the CDF: sf(x) = 1-cdf(x) and similarly for the log survival function. More stable definitions should be implemented in future CLs for distributions, for which they exist. Added a test to `distribution.Uniform` where we will use the default behaviour. PiperOrigin-RevId: 443652231
copybara-service
bot
force-pushed
the
test_443160366
branch
from
10bd0db
to
906ecb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add survival and log-survival function to
distrax.Distributionbase class.Note that by default we use a numerically not necessarily stable definition
of the survival function in terms of the CDF: sf(x) = 1-cdf(x) and similarly
for the log survival function.
More stable definitions should be implemented in future CLs for distributions,
for which they exist.
Added a test to
distribution.Uniformwhere we will use the default behaviour.