Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is functions are const funtctions in port.h #2101

Conversation

PeterPocsi
Copy link

All the "Is" functions should be const functions (like several other like IsDone).

@google-cla
Copy link

google-cla bot commented May 31, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@PeterPocsi
Copy link
Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 31, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@PeterPocsi PeterPocsi force-pushed the fix/api2-port-is-functions-const branch from 6243578 to b718099 Compare May 31, 2021 08:54
@PeterPocsi PeterPocsi closed this May 31, 2021
@PeterPocsi PeterPocsi deleted the fix/api2-port-is-functions-const branch May 31, 2021 08:58
@PeterPocsi PeterPocsi restored the fix/api2-port-is-functions-const branch May 31, 2021 08:59
@PeterPocsi
Copy link
Author

@googlebot I fixed it.

@PeterPocsi PeterPocsi reopened this May 31, 2021
@jiuqiant
Copy link
Contributor

jiuqiant commented Sep 1, 2021

Thanks for reporting this. Fixed in our internal code base upstream, and will be pushed to GitHub in the next release.

@jiuqiant jiuqiant self-assigned this Sep 1, 2021
@jiuqiant
Copy link
Contributor

jiuqiant commented Sep 2, 2021

Merged in 6abec12.

@jiuqiant jiuqiant closed this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants