PR #95959: Include math.h in elementwise.cc#2627
Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
Closed
PR #95959: Include math.h in elementwise.cc#2627copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Imported from GitHub PR tensorflow/tensorflow#95959 This is required to build with the most recent version of LLVM's libc++, which moved the `abs` function from `stdlib.h` to `math.h` in llvm/llvm-project#139586. Copybara import of the project: -- 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 by Devon Loehr <dloehr@google.com>: Include math.h in elementwise.cc Merging this change closes #95959 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#95959 from DKLoehr:math 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 PiperOrigin-RevId: 775719122
f6f10e1 to
2c6774d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #95959: Include math.h in elementwise.cc
Imported from GitHub PR tensorflow/tensorflow#95959
This is required to build with the most recent version of LLVM's libc++, which moved the
absfunction fromstdlib.htomath.hin llvm/llvm-project#139586.Copybara import of the project:
--
2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6 by Devon Loehr dloehr@google.com:
Include math.h in elementwise.cc
Merging this change closes #95959
FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#95959 from DKLoehr:math 2fa2ab36dae8afc9cf838a5ce1726e4ba48afec6