[公司職稱頁面] 讓搜尋框不受分頁影響 #1423
Merged
[公司職稱頁面] 讓搜尋框不受分頁影響 #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark86092
reviewed
Aug 28, 2024
mark86092
reviewed
Aug 28, 2024
|
Overview 也用到 salary_work_time_statistics 相關的資料，有考慮替換掉 Overview 來自 redux 的資料嗎？ |
剛看 Overview 的資料和 TimeAndSalaryStatistics 的資料互斥，所以他們不會共用 |
mark86092
reviewed
Aug 28, 2024
| @@ -30,7 +30,20 @@ const OvertimeSection = ({ statistics }) => { | |||
| }; | |||
|
|
|||
| OvertimeSection.propTypes = { | |||
| statistics: PropTypes.object.isRequired, | |||
| statistics: PropTypes.shape({ | |||
| average_estimated_hourly_wage: PropTypes.number.isRequired, | |||
There was a problem hiding this comment.
[optional] 這個參數目前有用到嗎？
mark86092
reviewed
Aug 28, 2024
src/graphql/jobTitle.js
Outdated
There was a problem hiding this comment.
[optional] 應該也有一些欄位是可以移除的 （ref: src/graphql/company.js ）
mark86092
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1416
這個 PR 是？
原本公司職稱頁面的資料是用
StatusRenderer處理，其中包含Searchbar這個 PR 將
Searchbar拉出StatusRenderer以獨立於分頁資料另外在薪資頁面將統計資料獨立於薪時資料，使得統計資料不因搜尋影響
另外
Searchbar也做簡單的化簡，並且修改 debounce time 成 1.5 秒Screenshots
Before
2024-08-28.8.21.20.mov
After
2024-08-28.1.01.26.mov
我應該如何手動測試？