feat(gooddata-pipelines): add workspace restore #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmatzek
force-pushed
the
jmat-SVS-1198-add-restore-logic-to-gooddata-pipelines
branch
6 times, most recently
from
4773086 to
95d1d23
Compare
janmatzek
force-pushed
the
jmat-SVS-1198-add-restore-logic-to-gooddata-pipelines
branch
from
95d1d23 to
163731c
Compare
janmatzek
requested review from
hkad98,
jaceksan,
lupko and
pcerny
as code owners
hkad98
reviewed
Oct 10, 2025
|
|
||
|
|
||
| @attrs.define | ||
| class JsonUtils: |
There was a problem hiding this comment.
Nitpick: consider using rjson, it should be faster. Do not forget to check the license. We added it previously for tests, so it was fine.
There was a problem hiding this comment.
If we add it here it becomes a part of the release and I think we would need SPACE approval for that. But making the switch easier in the future is pretty much the point of having this class :)
There was a problem hiding this comment.
At first glance, it should be safe. I can see Apache 2 and MIT. Also, I can see we already have this dependency for flexconnect. Feel free to use it then ;)
hkad98
approved these changes
Oct 10, 2025
janmatzek
deleted the
jmat-SVS-1198-add-restore-logic-to-gooddata-pipelines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: SVS-1198