What to do about trio.Process.aclose()
?
#356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been deprecated since
0.20.0
and we need to implement hard killsemantics ourselves now instead of relying on the prior
trio.Process.aclose()
wrapping; see #330!Progress
we need to sync withtrio
upstream to figure out what the plan isfor getting the functionality out of the old
Process.aclose()
if westill need it in our spawning layer.
trio.Process
deprecations #330 for the details on all that and history behind the apichanges in
trio
.trio.Process.aclose()
directlyfor now what was an attempt to fix the
mypy
run...aclose()
implementation into ourdo_hard_kill()
with comments on the original source.mypy
run clean!