Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about trio.Process.aclose()? #356

Merged
merged 3 commits into from
May 15, 2023
Merged

What to do about trio.Process.aclose()? #356

merged 3 commits into from
May 15, 2023

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented Apr 2, 2023

It's been deprecated since 0.20.0 and we need to implement hard kill
semantics ourselves now instead of relying on the prior
trio.Process.aclose() wrapping; see #330!


Progress

  • we need to sync with trio upstream to figure out what the plan is
    for getting the functionality out of the old Process.aclose() if we
    still need it in our spawning layer.
  • First commit is just directly calling trio.Process.aclose() directly
    for now what was an attempt to fix the mypy run..
  • copy out the old .aclose() implementation into our
    do_hard_kill() with comments on the original source.
  • get mypy run clean!
  • nooz file 😎

goodboy added 2 commits April 2, 2023 14:34
Move it into our `_spawn.do_hard_kill()` since we do indeed rely on
the particular process killing sequence on "soft kill" failure cases.
@goodboy goodboy marked this pull request as ready for review May 14, 2023 23:33
@goodboy goodboy requested a review from guilledk May 14, 2023 23:33
@goodboy goodboy merged commit 0f7db27 into master May 15, 2023
@goodboy goodboy deleted the drop_proc_actxmngr branch May 15, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants