Re-draw pdbpp prompt on SIGINT
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdlib has all sorts of muckery with ignoring SIGINT in the `Pdb._cmdloop()` but here we just override all that since we don't trust their decisions about cancellation handling whatsoever. Adds a `Lock.repl: MultiActorPdb` attr which is set by any task which acquires root TTY lock indicating (via actor global state) that the current actor is using the debugger REPL and can be expected to re-draw the prompt on SIGINT. Further we mask out log messages from any actor who also has the `shield_sigint_handler()` enabled to avoid logging noise when debugging.
goodboy
added
bug
goodboy
changed the title
pdbpp prompt on SIGINTpdbpp prompt on SIGINT
|
Lol, so as was my hair ripping ayer, it turns out the behavior of this is quite different depending on the shell in use... For example the tests are failing right now with
and whereas my issue hacking on this yesterday was that So I guess probably need to force bash when running the tests locally somehow as well as somehow hack this actual UX where we're seeing 2x |
guilledk
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long running issue todo with ctl-c during
pdbppREPL use to ensure that the prompt is always redrawn after log msgs indicating that the SIGINT is being ignored in whatever actor currently owns the TTY lock / is running a REPL.Also, this resolves the issues (AFAIK) that were preventing us from using the
pypiversion ofpdbppas mentioned in #323. So we should be able to do a working release again 😂 ?Probably pertains to: