Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immediate remote cancels #245

Merged
merged 25 commits into from
Oct 17, 2021
Merged

Immediate remote cancels #245

merged 25 commits into from
Oct 17, 2021

Commits on Oct 14, 2021

  1. Configuration menu
    Copy the full SHA
    7643bbf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41f0992 View commit details
    Browse the repository at this point in the history
  3. Do immediate remote task cancels

    As for `Actor.cancel()` requests, do the same for
    `Actor._cancel_task()` but use `_invoke()` to ensure
    correct msg transactions with caller. Don't cancel task
    cancels on a cancel-all-tasks operation in attempt at
    more determinism.
    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    bb9d9c7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    46ff558 View commit details
    Browse the repository at this point in the history
  5. Lol, fix sub-actor case

    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    2df16c1 View commit details
    Browse the repository at this point in the history
  6. Simplify to soft and hard reap sequences

    This is actually surprisingly easy to grok having gone through a lot of
    pain understanding edge cases in the zombie lord dev branch. Basically
    we just need to make sure actors are managed in a 2 step reap sequence.
    In the "soft" reap phase we wait for the process to terminate on its own
    concurrently with (maybe) waiting for its portal's final result (if it's
    a `.run_in_actor()`). If this path is cancelled or errors, then we do
    a "hard" reap where we timeout and send a signal to the proc to
    terminate immediately. The only last remaining trick is to tie in the
    root-is-debugger-aware logic to yet again avoid tty clobbers.
    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    77ec290 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    893bad7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6203507 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f3a6ab6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    d30ce96 View commit details
    Browse the repository at this point in the history
  11. Add tty lock acquire ctx mngr

    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    4b2710b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    daa28ea View commit details
    Browse the repository at this point in the history
  13. Adjust debugger tests to expect depth > 1 crashes

    With the new fixes to the trio spawner we can expect that both root
    *and* depth > 1 nursery owning actors will now not clobber any children
    that are in debug (either via breakpoint or through crashing). The tests
    changed now include more checks which ensure the 2nd level parent-ish
    actors also bubble up through into `pdb` and don't kill any of their
    (crashed) children before they're done themselves debugging.
    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b14699d View commit details
    Browse the repository at this point in the history
  14. Fix missing task status type

    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    6f5c35d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    fa317d1 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9d83ef8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7ee121a View commit details
    Browse the repository at this point in the history
  18. Pass uid not actor object

    goodboy committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    51259c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Configuration menu
    Copy the full SHA
    533457c View commit details
    Browse the repository at this point in the history
  2. Add nooz

    goodboy committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a42ec1f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e4ed0fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4f222a5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d827f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5cfac58 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b3c4851 View commit details
    Browse the repository at this point in the history