-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immediate remote cancels #245
Merged
Merged
Commits on Oct 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7643bbf - Browse repository at this point
Copy the full SHA 7643bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 41f0992 - Browse repository at this point
Copy the full SHA 41f0992View commit details -
Do immediate remote task cancels
As for `Actor.cancel()` requests, do the same for `Actor._cancel_task()` but use `_invoke()` to ensure correct msg transactions with caller. Don't cancel task cancels on a cancel-all-tasks operation in attempt at more determinism.
Configuration menu - View commit details
-
Copy full SHA for bb9d9c7 - Browse repository at this point
Copy the full SHA bb9d9c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46ff558 - Browse repository at this point
Copy the full SHA 46ff558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2df16c1 - Browse repository at this point
Copy the full SHA 2df16c1View commit details -
Simplify to soft and hard reap sequences
This is actually surprisingly easy to grok having gone through a lot of pain understanding edge cases in the zombie lord dev branch. Basically we just need to make sure actors are managed in a 2 step reap sequence. In the "soft" reap phase we wait for the process to terminate on its own concurrently with (maybe) waiting for its portal's final result (if it's a `.run_in_actor()`). If this path is cancelled or errors, then we do a "hard" reap where we timeout and send a signal to the proc to terminate immediately. The only last remaining trick is to tie in the root-is-debugger-aware logic to yet again avoid tty clobbers.
Configuration menu - View commit details
-
Copy full SHA for 77ec290 - Browse repository at this point
Copy the full SHA 77ec290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 893bad7 - Browse repository at this point
Copy the full SHA 893bad7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6203507 - Browse repository at this point
Copy the full SHA 6203507View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3a6ab6 - Browse repository at this point
Copy the full SHA f3a6ab6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d30ce96 - Browse repository at this point
Copy the full SHA d30ce96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2710b - Browse repository at this point
Copy the full SHA 4b2710bView commit details -
Configuration menu - View commit details
-
Copy full SHA for daa28ea - Browse repository at this point
Copy the full SHA daa28eaView commit details -
Adjust debugger tests to expect depth > 1 crashes
With the new fixes to the trio spawner we can expect that both root *and* depth > 1 nursery owning actors will now not clobber any children that are in debug (either via breakpoint or through crashing). The tests changed now include more checks which ensure the 2nd level parent-ish actors also bubble up through into `pdb` and don't kill any of their (crashed) children before they're done themselves debugging.
Configuration menu - View commit details
-
Copy full SHA for b14699d - Browse repository at this point
Copy the full SHA b14699dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f5c35d - Browse repository at this point
Copy the full SHA 6f5c35dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa317d1 - Browse repository at this point
Copy the full SHA fa317d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d83ef8 - Browse repository at this point
Copy the full SHA 9d83ef8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ee121a - Browse repository at this point
Copy the full SHA 7ee121aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51259c4 - Browse repository at this point
Copy the full SHA 51259c4View commit details
Commits on Oct 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 533457c - Browse repository at this point
Copy the full SHA 533457cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a42ec1f - Browse repository at this point
Copy the full SHA a42ec1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4ed0fd - Browse repository at this point
Copy the full SHA e4ed0fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f222a5 - Browse repository at this point
Copy the full SHA 4f222a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d827f7 - Browse repository at this point
Copy the full SHA 5d827f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cfac58 - Browse repository at this point
Copy the full SHA 5cfac58View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3c4851 - Browse repository at this point
Copy the full SHA b3c4851View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.