Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New discretization function #39

Open
artemy-bakulin opened this issue Jul 3, 2022 · 3 comments
Open

New discretization function #39

artemy-bakulin opened this issue Jul 3, 2022 · 3 comments

Comments

@artemy-bakulin
Copy link
Collaborator

Replaced the old discretization functions with a new one which is more concise and slightly more effective. Done with a 6cc934d commit.

I have tested this new function against the old methods using simulated data. The results are as follows:
| split | hist | discretize (new function)
TNR | 0.93| 0.92 | 0.93
TPR | 0.91 | 0.92 | 0.92

Also changed the order of discretization. Now the expression is discretized after the subsetting.

Added raw_expression attribute which contains unprocessed expression, which is used for subsetting and also in future will be used for estimating the regulator's expression in heatmaps.

@artemy-bakulin
Copy link
Collaborator Author

Fixed problems with "repr" in ExpressionProfile class

59e69e8

@artemy-bakulin
Copy link
Collaborator Author

Then I edited test_run.py in cefa39b

@artemy-bakulin
Copy link
Collaborator Author

Then edited test_expression.py in 4473b4f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant