Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Heatmap kwargs to the user from PAGE.heatmap() #37

Open
noamteyssier opened this issue Jun 28, 2022 · 2 comments
Open

Expose Heatmap kwargs to the user from PAGE.heatmap() #37

noamteyssier opened this issue Jun 28, 2022 · 2 comments
Labels
API Improvements or additions to the API enhancement New feature or request

Comments

@noamteyssier
Copy link
Collaborator

The keyword arguments for Heatmap should be exposed to the user and accessible from the PAGE object directly via the .heatmap() method added in cc92d04.

This could be done simply by passing the kwargs (**kwargs) into heatmap.

@noamteyssier noamteyssier added enhancement New feature or request API Improvements or additions to the API labels Jun 28, 2022
@artemy-bakulin
Copy link
Collaborator

I completely agree, I have already moved heatmap outside of the PAGE run execution. A pull request will follow soon.

@abearab
Copy link
Member

abearab commented Nov 26, 2023

@artemy-bakulin – In the documents for Heatmap class you have fig and ax but I think it's not implemented to take them as optional inputs, right?

class Heatmap(builtins.object)
 |  Heatmap(pathways: numpy.ndarray, graphical_ar: numpy.ndarray, regulator_exp: Optional[numpy.ndarray] = None, cmap_main: Optional[str] = 'viridis', cmap_reg: Optional[str] = 'plasma')
 |  
 |  An object which is used to build a heatmap, representing pathway deregulation
 |  Attributes
 |  ==========
 |  pathways: np.ndarray
 |  graphical_ar: np.ndarray
 |  regulator_exp: np.ndarray
 |  cmap_main: str
 |  cmap_reg: str
 |  n_pathways: int
 |  n_bins: int
 |  isreg: bool
 |  fig: matplotlib.figure.Figure
 |  ax: matplotlib.figure.Axes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Improvements or additions to the API enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants