-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
77 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I have a review comment for this change, I hope you can make use of it to make the code better.
As a personal thought, mentioning that a method is deprecated as the very last word in the documentation seems exact opposite of what it should be - the very first word you see. Otherwise a developer may spend more time reading the entire doc string before realizing this func is deprecated.
Officially speaking, there's supposedly a Go convention already set, see golang/go#10909. However, it's really hard to parse from the linked thread what is the convention that was decided. I hope you're successful in finding it.